Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix #1054

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
typo fix
jthomas-orcid committed Nov 2, 2023
commit 09b5060897f5bee51bc9781c1c55ab6f8676c2c7
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -172,7 +172,7 @@ services:

ui:
restart: unless-stopped
image: ${DOCKER_REG}/ui:${TAG:}
image: ${DOCKER_REG}/ui:${TAG}
environment:
- 'SPRING_PROFILES_ACTIVE=prod'
- OAUTH2_WEB_CLIENT_CONFIGURATION_SECRET=${WEB_CLIENT_CONFIGURATION_SECRET}

Unchanged files with check annotations Beta

let component: LoginComponent
let fixture: ComponentFixture<LoginComponent>
let loginService: jasmine.SpyObj<LoginService>
let stateStorageService: jasmine.SpyObj<StateStorageService>

Check warning on line 14 in ui/src/app/account/login/login.component.spec.ts

GitHub Actions / format

'stateStorageService' is assigned a value but never used
let accountService: jasmine.SpyObj<AccountService>
beforeEach(() => {
this.loginService
.login({
username: this.loginForm.get('username')!.value!,

Check warning on line 75 in ui/src/app/account/login/login.component.ts

GitHub Actions / format

Forbidden non-null assertion

Check warning on line 75 in ui/src/app/account/login/login.component.ts

GitHub Actions / format

Forbidden non-null assertion
password: this.loginForm.get('password')!.value!,

Check warning on line 76 in ui/src/app/account/login/login.component.ts

GitHub Actions / format

Forbidden non-null assertion

Check warning on line 76 in ui/src/app/account/login/login.component.ts

GitHub Actions / format

Forbidden non-null assertion
mfaCode: this.loginForm.get('mfaCode')?.value,
})
.subscribe({
this.mfaSent = false
},
// TODO: review any type
error: (err) => {

Check warning on line 101 in ui/src/app/account/login/login.component.ts

GitHub Actions / format

'err' is defined but never used
this.loginService.logout()
this.authenticationError = true
},
export interface ILoginResult {
mfaRequired: boolean
oauth2AccessToken?: any

Check warning on line 3 in ui/src/app/account/model/login.model.ts

GitHub Actions / format

Unexpected any. Specify a different type
}
export interface ILoginCredentials {
import { Injectable } from '@angular/core'
import { SessionStorageService } from 'ngx-webstorage'
import { HttpClient, HttpHeaders, HttpResponse } from '@angular/common/http'
import { BehaviorSubject, EMPTY, Observable, Subject, catchError, map, of, takeUntil, tap } from 'rxjs'

Check warning on line 4 in ui/src/app/account/service/account.service.ts

GitHub Actions / format

'of' is defined but never used

Check warning on line 4 in ui/src/app/account/service/account.service.ts

GitHub Actions / format

'tap' is defined but never used
import { SERVER_API_URL } from '../../../app/app.constants'
import { IAccount } from '../model/account.model'
private isFetchingAccountData = false
private stopFetchingAccountData = new Subject()
private authenticated = false
private authenticationState = new BehaviorSubject<any>(null)

Check warning on line 17 in ui/src/app/account/service/account.service.ts

GitHub Actions / format

Unexpected any. Specify a different type
private logoutAsResourceUrl = SERVER_API_URL + 'services/userservice/api'
constructor(