add null check to url validator

ORCID · Aug 4, 2023 · ae710b3 · ae710b3
1 parent ef854c7
commit ae710b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...c/main/webapp/app/home/member-info-landing/member-info-edit/member-info-edit.component.ts b/...c/main/webapp/app/home/member-info-landing/member-info-edit/member-info-edit.component.ts
@@ -113,7 +113,7 @@ export class MemberInfoEditComponent implements OnInit, OnDestroy {
   }
 
   validateUrl() {
-    if (!/(http(s?)):\/\//i.test(this.memberData.website)) {
+    if (this.memberData.website && !/(http(s?)):\/\//i.test(this.memberData.website)) {
       this.memberData.website = 'http://' + this.memberData.website;
     }
   }
@@ -184,6 +184,7 @@ export class MemberInfoEditComponent implements OnInit, OnDestroy {
       this.invalidForm = false;
       this.isSaving = true;
       const details: ISFMemberUpdate = this.createDetailsFromForm();
+
       this.memberService.updateMemberDetails(details, this.memberData.id).subscribe(
         res => {
           this.memberService.memberData.next({

diff --git a/gateway/src/main/webapp/app/home/member-info-landing/member-info-landing.component.ts b/gateway/src/main/webapp/app/home/member-info-landing/member-info-landing.component.ts
@@ -35,7 +35,7 @@ export class MemberInfoLandingComponent implements OnInit, OnDestroy {
   }
 
   validateUrl() {
-    if (!/(http(s?)):\/\//i.test(this.memberData.website)) {
+    if (this.memberData.website && !/(http(s?)):\/\//i.test(this.memberData.website)) {
       this.memberData.website = 'http://' + this.memberData.website;
     }
   }
@@ -71,7 +71,6 @@ export class MemberInfoLandingComponent implements OnInit, OnDestroy {
   }
 
   stopManagingMember() {
-    // empty string if it's not working
     this.memberService.setManagedMember(null);
     this.memberService.fetchMemberData(this.account.salesforceId);
   }