Merge pull request #1030 from ORCID/rollbackBreakingChangesForNotific…

…ations removed user access check for updating member language
ORCID · Aug 7, 2023 · 369af8e · 369af8e
2 parents 5b33731 + a5b9d7f
commit 369af8e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/...r-service/src/main/java/org/orcid/memberportal/service/member/services/MemberService.java b/...r-service/src/main/java/org/orcid/memberportal/service/member/services/MemberService.java
@@ -315,8 +315,6 @@ public MemberOrgIds getCurrentMemberOrgIds(String salesforceId) throws Unauthori
     }
 
     public void updateMemberDefaultLanguage(String salesforceId, String language) throws UnauthorizedMemberAccessException {
-        LOG.info("Logged in user is {}, language is {}", userService.getLoggedInUser().getEmail());
-        validateUserAccess(salesforceId);
         Optional<Member> optional = memberRepository.findBySalesforceId(salesforceId);
         if (optional.isPresent()) {
             Member member = optional.get();

diff --git a/...rvice/src/test/java/org/orcid/memberportal/service/member/services/MemberServiceTest.java b/...rvice/src/test/java/org/orcid/memberportal/service/member/services/MemberServiceTest.java
@@ -696,17 +696,6 @@ void testUpdateMemberDefaultLanguage() throws UnauthorizedMemberAccessException
         assertThat(captured.getDefaultLanguage()).isEqualTo("en");
     }
 
-    @Test
-    void testUpdateMemberDefaultLanguage_illegalAccess() {
-        Member member = getMember();
-        Mockito.when(memberRepository.findBySalesforceId(Mockito.eq("wrongSalesforceId"))).thenReturn(Optional.of(member));
-
-        Assertions.assertThrows(UnauthorizedMemberAccessException.class, () -> {
-                memberService.updateMemberDefaultLanguage("wrongSalesforceId", "en");
-            });
-        Mockito.verify(memberRepository, Mockito.never()).save(Mockito.any(Member.class));
-    }
-
     @Test
     void testProcessMemberContact_add() throws UnauthorizedMemberAccessException {
         Mockito.doNothing().when(mailService).sendUpdateContactEmail(Mockito.any(MemberContactUpdate.class));