Merge pull request #148 from ORCID/CleanUp

Remove tests for keywords and membership
ORCID · Jun 15, 2023 · 33832b4 · 33832b4
2 parents 1d668a6 + b628f61
commit 33832b4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/orcid/test_30api_all_endpoints.py b/orcid/test_30api_all_endpoints.py
@@ -139,9 +139,7 @@ def test_othername30(self):
 
     # https://github.com/ORCID/orcid-cypress_tests-private/blob/main/cypress/e2e/mapi/v3_0/crud_address_v30.cy.js
 
-    def test_keywords30(self):
-        jsontext = '"content":"oranges"}'
-        self.bio20('20postkeyword.xml', 'keywords', 'keywords', jsontext, 'apples', 'oranges', 'bananas')
+    # https://github.com/ORCID/orcid-cypress_tests-private/blob/main/cypress/e2e/mapi/v3_0/crud_keywords_v30.cy.js
 
     def test_researcherurls30(self):
         jsontext = '"url-name":"Bing","url":{"value":"www.bing.com"}}'
@@ -157,9 +155,7 @@ def test_researcherurls30(self):
 
     # https://github.com/ORCID/orcid-cypress_tests-private/blob/main/cypress/e2e/mapi/v3_0/crud_invited_position_v30.cy.js
 
-    def test_membership30(self):
-        jsontext = '"department-name":"Rocket Science","role-title":"BA","start-date" : {"year" : {"value" : "2001"}},"organization":{"name":"University of Oxford ","address":{"city":"Oxford","region":"Oxfordshire","country":"GB"},"disambiguated-organization" : {"disambiguated-organization-identifier":"6396","disambiguation-source" : "RINGGOLD"}}}'
-        self.bio20('30postmembership.xml', 'membership', 'memberships', jsontext, 'Annapolis', 'Oxford', 'AARP')
+    # https://github.com/ORCID/orcid-cypress_tests-private/blob/main/cypress/e2e/mapi/v3_0/crud_membership_v30.cy.js
 
     def test_qualification30(self):
         jsontext = '"department-name":"Rocket Science","role-title":"BA","start-date" : {"year" : {"value" : "2001"}},"organization":{"name":"University of Oxford ","address":{"city":"Oxford","region":"Oxfordshire","country":"GB"},"disambiguated-organization" : {"disambiguated-organization-identifier":"6396","disambiguation-source" : "RINGGOLD"}}}'

diff --git a/orcid/test_member30_api_post_update.py b/orcid/test_member30_api_post_update.py
@@ -54,17 +54,7 @@ def test_post_qualification(self):
 
     # https://github.com/ORCID/orcid-cypress_tests-private/blob/main/cypress/e2e/mapi/v3_0/crud_research_resource_v30.cy.js
 
-    def test_post_update_keyword(self):
-        # Post a keyword using 3.0 to the record created for testing today
-        response = self.post_activity(self.version, "keywords", "ma30_keyword.xml")
-        self.assertTrue("HTTP/1.1 201" in response, "Response missing \"201\" code: " + response)
-        putcode = self.get_putcode_from_response(response)
-        self.assertIsNotNone(putcode,"Not valid putcode returned: [%s]" % str(putcode))
-        #Update the keyword from pear to grapes
-        self.assertFalse("" == putcode, "Empty putcode in url")
-        updated_data = '{"put-code":' + str(putcode) + ',"content":"apricots"}'
-        update_response = self.update_activity(self.version, putcode, updated_data, "keywords")
-        self.assertTrue("HTTP/1.1 200" in update_response, str(putcode) + " > Update Action Response: " + update_response + " with data [%s]" % updated_data)
+    # https://github.com/ORCID/orcid-cypress_tests-private/blob/main/cypress/e2e/mapi/v3_0/crud_keywords_v30.cy.js
 
     def test_post_othername(self):
         # Post an other name using 3.0 to the record created for testing today