Use EFFECTIVE_USER_ORCID instead of REAL_USER_ORCID to avoid problems…

… when doing delegation mode
ORCID · Jul 28, 2022 · f27c6cd · f27c6cd
1 parent a93299e
commit f27c6cd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/app/record/components/work-contributor-role/work-contributor-roles.component.spec.ts b/src/app/record/components/work-contributor-role/work-contributor-roles.component.spec.ts
@@ -173,7 +173,7 @@ function getContributor(): Contributor[] {
 function getUserRecord(): UserRecord {
   return {
     userInfo: {
-      REAL_USER_ORCID: '0000-0000-0000-000X',
+      EFFECTIVE_USER_ORCID: '0000-0000-0000-000X',
     },
   } as UserRecord
 }
diff --git a/src/app/record/components/work-contributor-role/work-contributor-roles.component.ts b/src/app/record/components/work-contributor-role/work-contributor-roles.component.ts
@@ -144,7 +144,7 @@ export class WorkContributorRolesComponent implements OnInit {
   private getRecordHolderContribution(): Contributor {
     return this.contributors?.find(
       (c) =>
-        c?.contributorOrcid?.path === this.userRecord?.userInfo?.REAL_USER_ORCID
+        c?.contributorOrcid?.path === this.userRecord?.userInfo?.EFFECTIVE_USER_ORCID
     )
   }
 }
diff --git a/src/app/record/components/work-contributors/work-contributors.component.ts b/src/app/record/components/work-contributors/work-contributors.component.ts
@@ -52,7 +52,9 @@ export class WorkContributorsComponent implements OnInit, OnDestroy {
   }
 
   ngOnInit(): void {
-    this.id = this.userRecord?.userInfo?.REAL_USER_ORCID
+    // EFFECTIVE_USER_ORCID keeps the ORCID id of the user you are on.
+    // REAL_USER_ORCID will contain the orcid id of a delegator when on delegation mode.
+    this.id = this.userRecord?.userInfo?.EFFECTIVE_USER_ORCID
     this.platform
       .get()
       .pipe(takeUntil(this.$destroy))