Fix dangling reference as cell returns a copy of geometry now. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When geometry() returned a reference we could simply store a reference to its stored center. With the geometry returned as a copy this has become a dangling reference. We fix this by storing a constant reference to the geometry and then reference its center.
|
Should we jenkins and merge this now? I don't see the need to wait for OPM/opm-grid#334? |
|
This fix seems to be at the wrong place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When geometry returned a reference we could simply store a
reference to its stored center. With geometry returned as a copy this
has become a dangling reference. We fix this by storing a constant reference
to the geometry and then reference its center.
This change is needed for the PR OPM/opm-grid#334