Activate WELPI and WPIMULT for use in PyAction #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisajulia
force-pushed
the
feature/pyAction-insert-kw-WELPI-WPIMULT
branch
3 times, most recently
from
8d29f0f to
ef10afa
Compare
lisajulia
force-pushed
the
feature/pyAction-insert-kw-WELPI-WPIMULT
branch
from
ef10afa to
fa911bd
Compare
lisajulia
force-pushed
the
feature/pyAction-insert-kw-WELPI-WPIMULT
branch
from
fa911bd to
5157e95
Compare
blattms
reviewed
Jul 5, 2024
lisajulia
force-pushed
the
feature/pyAction-insert-kw-WELPI-WPIMULT
branch
2 times, most recently
from
ea366df to
955db92
Compare
|
I am not sure how the performance implications of this are. It seems like we now always get all the WELPI of all wells even without any PYACTION if there is an actionx (even without WELPI). This is more information/computation then we need. Do you see a possibility to get only the needed ones if there is no PYACTION? I think getting them at once is an improvement. |
|
Should we reset the welpimap in the schedule somewhen? |
lisajulia
force-pushed
the
feature/pyAction-insert-kw-WELPI-WPIMULT
branch
3 times, most recently
from
7c8173d to
91338bd
Compare
lisajulia
force-pushed
the
feature/pyAction-insert-kw-WELPI-WPIMULT
branch
from
91338bd to
465b895
Compare
…to a pyaction call; fetch the wellPImap once, before the execution of potential PyActions and ActionXs
lisajulia
force-pushed
the
feature/pyAction-insert-kw-WELPI-WPIMULT
branch
from
465b895 to
83f2485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reference manual: With this PR and OPM/opm-common#4136, the keywords WELPI and WPIMULT can be used in the "insert keywords"-function in Pyaction.