Build opm modules in manylinux container #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version tries to use the generated pybind11 modules opmcommon_python.so and simulators.so from the host system, but auditwheel in the manylinux docker container will not be able to repair those if they were compiled with a too recent toolchain on the host. I think we need to build both pybind11 modules inside the manylinux docker container also.
Build opm-common, opm-grid, opm-models, and opm-simulators inside a manylinux docker container. Each module is installed to /opt/opm inside the container. Finally, all build artifacts are deleted (except for the /opt/opm directory) from the generated image to reduce its size. This image can later be used as a base image when building opm-python in a manylinux container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #6.
Build
opm-common,opm-grid,opm-models, andopm-simulatorsinside a manylinux docker container.Each module is installed to
/opt/opminside the container and all build artifacts are deleted (except for the/opt/opmdirectory) from the generated image to reduce its size. The plan is that this image can later be used as a base image when buildingopm-pythonin a manylinux container. This starts to address the issue reported in #6 (comment) by building not just the opm-python Python project in the manylinux container, but also all of the opm modules.Currently this is work in progress until it is clear if this will help
auditwheelto repair the generated wheel.