WIP: changed sequence of KWs to comply with eclipses standard #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sympathetic to the goal and your patch seems to be quite okay to me (be aware that I don't call the shots in this module), but if eclipse is this picky about keyword ordering et al. keeping the restart files compatible seems to be a major long term pain in the butt from the maintenance perspective!? |
|
Actually the project is currently on hold due to the complexity of the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small part of the project of making OPM restart files eclipse readable.
One requirement is that nothing uneclipse-like should be added after the STARTSOL keyword.
The proposed change here changes the keyword sequence.