Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On loadBalance(...) "addCornerCells" should be called "addEdgeCells"? #806

Closed
wants to merge 21 commits into from

Conversation

aritorto
Copy link
Member

In an attempt to assign unique point ids on a distributed grid with LGRs, I invoked loadBalance, enabling the inclusion of cells that share corners with interior cells on each process by setting addCornerCells = true (one of the function arguments in loadBalance). However, instead of adding corner-sharing cells, this configuration primarily adds cells that share edges, in addition to the overlap layer of size 1. As a result, cells that share only a corner are not included, which can impact the uniqueness of point ids in certain cases.

In the test addLgrsOnDistributedGrid_test.cpp, both escenarios are included:

  • cases where setting addCornerCells=true fix the issue of unique point ids
  • cases where setting addCornerCells=true is not enough to achieve unique point ids (cells that share only corners - and not edges - are not included)

Based on #802.

Not relevant for the Reference Manual.

@aritorto
Copy link
Member Author

jenkins build this serial please

@aritorto aritorto changed the title Function argument on loadBalance(...) "addCornerCells" should be called "addEdgeCells" Function argument on loadBalance(...) "addCornerCells" should be called "addEdgeCells"? Nov 27, 2024
@aritorto aritorto changed the title Function argument on loadBalance(...) "addCornerCells" should be called "addEdgeCells"? On loadBalance(...) "addCornerCells" should be called "addEdgeCells"? Nov 27, 2024
@aritorto
Copy link
Member Author

REplaced by #808 (too many merge conflicts here)

@aritorto aritorto closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant