Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return a copy for Geomerty::center()
This is mandated by the DUNE interface. It also makes a lot of sense because now people do not need to think whether const auto& center = entity.geometry().center(); might cause a dangling reference. It just wont as it is always a copy and never a reference to a member.
- Loading branch information
e48a468
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you really intend to push this directly to OPM/opm-grid:master?
e48a468
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I didn't and am very sorry. It was meant to end up in my repository in a branch. I accidentally commit thiese to master and not the branch that I am working wth and I issued a
git push
without a remote and git assumed that I wanted to push to the branch being tracked (which is this master). Ouch.e48a468
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks for the information. Do you want me to revert the commits or do you want to do it yourself? Is there a better follow-up action?
e48a468
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e48a468
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a friendly tip how I avoid this: Never use ssh for the origin remote, only my forks. The need to input user/pwd then point out the error.