Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate WELPI for use in PYACTION #4133

Closed
wants to merge 3 commits into from
Closed

Activate WELPI for use in PYACTION #4133

wants to merge 3 commits into from

Conversation

lisajulia
Copy link
Contributor

Test is in opm-tests

@OPM OPM deleted a comment from lisajulia Jul 2, 2024
@akva2
Copy link
Member

akva2 commented Jul 2, 2024

jenkins is not ready, please don't.

@lisajulia
Copy link
Contributor Author

jenkins is not ready, please don't.

Ah ok :) - thanks!

@lisajulia lisajulia force-pushed the feature/pyAction-insert-kw-WELPI branch from e69f084 to 49c2386 Compare July 2, 2024 16:32
@lisajulia
Copy link
Contributor Author

jenkins build this opm-simulators=5463 opm-tests=1190 please

@blattms
Copy link
Member

blattms commented Jul 4, 2024 •
edited
Loading

mmh. Somehow this looks like the timestepping did change for the existing regression test mpi.compareParallelSim_flow+ACTIONX_WELPI

Comparing summary files 

Checking 271  vectors  ... Program threw an exception: [/var/lib/jenkins/post-builder/workspace/opm-common-PR-builder/test_util/EclRegressionTest.cpp:1064] 
Keyword DAY summary vector of different length (76 != 74)

@lisajulia
Copy link
Contributor Author

mmh. Somehow this looks like the timestepping did change for the existing regression test mpi.compareParallelSim_flow+ACTIONX_WELPI

Comparing summary files 

Checking 271  vectors  ... Program threw an exception: [/var/lib/jenkins/post-builder/workspace/opm-common-PR-builder/test_util/EclRegressionTest.cpp:1064] 
Keyword DAY summary vector of different length (76 != 74)

This is a test that I actually added, yet this should still pass....

blattms
blattms reviewed Jul 4, 2024
View reviewed changes
opm/input/eclipse/Schedule/Schedule.cpp Show resolved Hide resolved
opm/input/eclipse/Schedule/Schedule.cpp
@@ -1640,6 +1646,8 @@ File {} line {}.)", pattern, location.keyword, location.filename, location.linen


SimulatorUpdate Schedule::runPyAction(std::size_t reportStep, const Action::PyAction& pyaction, Action::State& action_state, EclipseState& ecl_state, SummaryState& summary_state) {
// Set welpi_action_mode to true, this is necessary for the keyword WELPI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should explain why?

@lisajulia
Copy link
Contributor Author

mmh. Somehow this looks like the timestepping did change for the existing regression test mpi.compareParallelSim_flow+ACTIONX_WELPI

Comparing summary files 

Checking 271  vectors  ... Program threw an exception: [/var/lib/jenkins/post-builder/workspace/opm-common-PR-builder/test_util/EclRegressionTest.cpp:1064] 
Keyword DAY summary vector of different length (76 != 74)

This is a test that I actually added, yet this should still pass....

@blattms: I quickly checked: this test (which compares the parallel to the sequential run) also fails with the flow version I had compiled from the 2024.04 release ...

@blattms
Copy link
Member

blattms commented Jul 4, 2024

This is a test that I actually added, yet this should still pass....

I thought you added the PYACTION test PYACTION_WELPI_INSERT_KW.DATA, but here the comparison of ACTIONX_WELPI.DATA with the reference run fails.

@lisajulia
Copy link
Contributor Author

This is a test that I actually added, yet this should still pass....

I thought you added the PYACTION test PYACTION_WELPI_INSERT_KW.DATA, but here the comparison of ACTIONX_WELPI.DATA with the reference run fails.

I've added three tests:

  • one that compares PYACTION to ACTIONX (passing)
  • one that compares parallel PYACTION to sequential PYACTION (failing)
  • one that compares parallel ACTIONX to sequential ACTIONX (failing)

@lisajulia
Copy link
Contributor Author

mmh. Somehow this looks like the timestepping did change for the existing regression test mpi.compareParallelSim_flow+ACTIONX_WELPI

Comparing summary files 

Checking 271  vectors  ... Program threw an exception: [/var/lib/jenkins/post-builder/workspace/opm-common-PR-builder/test_util/EclRegressionTest.cpp:1064] 
Keyword DAY summary vector of different length (76 != 74)

This is a test that I actually added, yet this should still pass....

@blattms: I quickly checked: this test (which compares the parallel to the sequential run) also fails with the flow version I had compiled from the 2024.04 release ...

Thanks for clarifying, those tests might actually fail, I've removed them now.

@lisajulia lisajulia mentioned this pull request Jul 4, 2024
Open
@lisajulia
Copy link
Contributor Author

Closing, since #4136 contains everything relevant from this one

@lisajulia lisajulia closed this Jul 4, 2024
@lisajulia lisajulia deleted the feature/pyAction-insert-kw-WELPI branch July 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blattms blattms blattms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisajulia @akva2 @blattms