Grid calculator ensemble #12002
Merged
Grid calculator ensemble #12002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriben
force-pushed
the
grid-calculator-ensemble
branch
2 times, most recently
from
a400bab to
be98a28
Compare
magnesj
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Consider including my suggested fixes from https://github.com/OPM/ResInsight/tree/well-target-adjustments
| } | ||
|
|
||
| createResultVector( *targetCase, "OCCUPANCY", occupancy ); | ||
| auto createFractionVector = []( const std::vector<int>& occurrence, int maxOccurrence ) -> std::vector<double> |
There was a problem hiding this comment.
Rename maxOccurrence to realizationCount to make intention clearer.
Improvements: * Well Target Candidates: Add filtering by binary result * Well Target Candidates: make result grid cell count configurable. * Well Target Candidates: Improve ui ordering. * Well Target Candidates: compute probability, and simplify vector names. * Optimization: Avoid expensive unintended duplication of data
kriben
force-pushed
the
grid-calculator-ensemble
branch
from
af23087 to
0e1c62a
Compare
magnesj
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.