Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: build against QT 6.8 #11951

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fixed: build against QT 6.8 #11951

merged 1 commit into from
Dec 3, 2024

Conversation

akva2
Copy link
Member

@akva2 akva2 commented Dec 2, 2024

/home/akva/kode/opm/ResInsight/ApplicationLibCode/Application/Tools/RiaTextStringTools.cpp:212:22: error: redefinition of ‘std::strong_ordering operator<=>(const QString&, const QString&)’
  212 | std::strong_ordering operator<=>( const QString& lhs, const QString& rhs )
      |                      ^~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:63,
                 from /usr/include/x86_64-linux-gnu/qt6/QtCore/qregularexpression.h:9,
                 from /usr/include/x86_64-linux-gnu/qt6/QtCore/QRegularExpression:1,
                 from /home/akva/kode/opm/ResInsight/ApplicationLibCode/Application/Tools/RiaTextStringTools.h:21,
                 from /home/akva/kode/opm/ResInsight/ApplicationLibCode/Application/Tools/RiaTextStringTools.cpp:19:
/usr/include/x86_64-linux-gnu/qt6/QtCore/qstring.h:777:5: note: ‘std::strong_ordering operator<=>(const QString&, const QString&)’ previously defined here
  777 |     Q_DECLARE_STRONGLY_ORDERED(QString)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
[1192/2818] Building CXX object ApplicationLibCode/CMakeFiles/ApplicationLibCode.dir/Application/RiaPreferences.cpp.o
ninja: build stopped: subcommand failed.

I'm not entirely sure this was introduced in 6.8 but something like this is needed.

@akva2
Copy link
Member Author

akva2 commented Dec 2, 2024

i can't see how the python linting failure is caused by the changes so I will just ignore.

@magnesj
Copy link
Member

magnesj commented Dec 2, 2024

We are currently using 6.6, as we have seen issues with 6.7 related to theming. We will investigate newer Qt 6 versions after the release of 2024.12.

@magnesj
Copy link
Member

magnesj commented Dec 2, 2024

Copy link
Member

@magnesj magnesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@magnesj magnesj merged commit 6d4824b into OPM:dev Dec 3, 2024
6 of 7 checks passed
@akva2 akva2 deleted the fix_qt_6.8 branch December 3, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants