Qt6: Adjustments #11804
Merged
Qt6: Adjustments #11804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnesj
force-pushed
the
qt6-adjustments
branch
from
09b6eb7 to
671c919
Compare
In Qt6, the insertWidget function checks if the index parameter is valid based on current widgets present in the layout. This is error prone, and use addWidget to avoid manual counting of index. There are some places where insertWidget is still used, but it will require more work to fix these.
magnesj
force-pushed
the
qt6-adjustments
branch
from
6b553c1 to
690758f
Compare
magnesj
force-pushed
the
qt6-adjustments
branch
from
1fc1fb3 to
a974bb1
Compare
kriben
requested changes
Oct 25, 2024
ApplicationLibCode/FileInterface/RifCaseRealizationParametersReader.cpp
Outdated
Show resolved
Hide resolved
Replace use of QRegExp with QRegularExpression Remove dependency on qt5compat module Simplify an expression based on review
Run of regression tests in debug mode failed
The call stack when this assert happens indicates that there are more signals to be disconnected from the object. Crash is fixed by disconnecting all signals. Assert seen in debug build: ASSERT failure in caf::Viewer: "Called object is not of the correct type (class destructor may have already run)", file C:\Qt\6.6.3\msvc2019_64\include\QtCore/qobjectdefs_impl.h, line 130
Guard null pointer use in view linker. Remove complicated cleanup in destructor in Rim3dVew.
magnesj
force-pushed
the
qt6-adjustments
branch
from
cc428ba to
d9827fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11823
Closes #11816