Case view refactor #11291
Merged
Case view refactor #11291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriben
force-pushed
the
case-view-refactor
branch
3 times, most recently
from
0f703b6 to
db7d182
Compare
kriben
force-pushed
the
case-view-refactor
branch
7 times, most recently
from
ef46896 to
b443ee7
Compare
kriben
force-pushed
the
case-view-refactor
branch
from
b443ee7 to
5e1be40
Compare
magnesj
requested changes
Apr 15, 2024
There was a problem hiding this comment.
I think we need to hide the Views container below a case. Current implementation creates a lot of empty containers.
For some reason I had to fix compile issues in a file, see f1e3bef
Update version check to a more recent version.
ApplicationLibCode/ProjectDataModel/RimEclipseContourMapProjection.cpp
Outdated
Show resolved
Hide resolved
kriben
force-pushed
the
case-view-refactor
branch
from
f1e3bef to
72de136
Compare
magnesj
approved these changes
Apr 15, 2024
Eclipse grid views and contour maps are not longer a child of the case. The views are not separate collections (one for grid and one for contour maps) on root level.
kriben
force-pushed
the
case-view-refactor
branch
from
72de136 to
00bacd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.