-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDU wellpath import #11228
Merged
Merged
OSDU wellpath import #11228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriben
force-pushed
the
osdu-wellpaths
branch
3 times, most recently
from
May 3, 2024 07:07
e2d9dc2
to
f3a6e82
Compare
kriben
force-pushed
the
osdu-wellpaths
branch
2 times, most recently
from
May 13, 2024 13:51
705fa5f
to
806ef47
Compare
kriben
force-pushed
the
osdu-wellpaths
branch
2 times, most recently
from
May 22, 2024 14:24
dbdbd9a
to
9789e0e
Compare
magnesj
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well organized PR. Minor layout issues.
I think all copyright years can be updated to 2024 for all modified files based on original ssihub code.
ApplicationLibCode/Commands/OsduImportCommands/RiaOsduConnector.cpp
Outdated
Show resolved
Hide resolved
ApplicationLibCode/Commands/OsduImportCommands/RiaOsduOAuthHttpServerReplyHandler.h
Outdated
Show resolved
Hide resolved
ApplicationLibCode/Commands/OsduImportCommands/RicWellPathsImportOsduFeature.cpp
Show resolved
Hide resolved
ApplicationLibCode/Commands/OsduImportCommands/RicWellPathsImportOsduFeature.cpp
Outdated
Show resolved
Hide resolved
ApplicationLibCode/Commands/OsduImportCommands/RicWellPathsImportOsduFeature.cpp
Outdated
Show resolved
Hide resolved
ApplicationLibCode/Commands/OsduImportCommands/RimWellPathImport.cpp
Outdated
Show resolved
Hide resolved
magnesj
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.