Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve summary calculation performance #11225

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Improve summary calculation performance #11225

merged 8 commits into from
Feb 26, 2024

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Feb 23, 2024

Closes #11224

@magnesj magnesj force-pushed the performance-calculations branch 2 times, most recently from fe58976 to c2a9338 Compare February 24, 2024 09:46
@magnesj magnesj marked this pull request as ready for review February 25, 2024 08:04
@magnesj magnesj requested a review from kriben February 25, 2024 08:04
…anged

- avoid recreation of summary file readers
- delete all nodes in address tree representing calculated curves
- build address nodes for calculated curves
@magnesj magnesj force-pushed the performance-calculations branch from fd3fa03 to 8637572 Compare February 25, 2024 08:28
@magnesj magnesj force-pushed the performance-calculations branch from 8637572 to 86ddf4b Compare February 25, 2024 09:01
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magnesj magnesj merged commit 672fbe1 into dev Feb 26, 2024
19 checks passed
@magnesj magnesj deleted the performance-calculations branch February 26, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary Calculator: Performance issue when creating new calculation
2 participants