Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signal handlers #11065

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add signal handlers #11065

merged 1 commit into from
Feb 2, 2024

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Jan 15, 2024

No description provided.

@magnesj magnesj force-pushed the wire-up-signal-handler branch from af433c6 to 85c6fe2 Compare January 31, 2024 13:42
@magnesj magnesj force-pushed the wire-up-signal-handler branch from 85c6fe2 to 60d79ab Compare January 31, 2024 14:10
@magnesj magnesj marked this pull request as ready for review January 31, 2024 19:32
@magnesj magnesj requested a review from kriben January 31, 2024 19:32
kriben
kriben approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks OK (with the caveats). Tried on my machine, and did not see log message from the signal handler.

@magnesj magnesj merged commit 06766b3 into dev Feb 2, 2024
21 checks passed
@magnesj magnesj deleted the wire-up-signal-handler branch February 2, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriben kriben kriben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnesj @kriben