#10720 Summary Import: support upper/lower case mismatch between file… #10738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name and extension. Importing files with different casing in base name and extension would fail when using libecl summary reader. E.g "norne_atw2013.SMSPEC" would fail since libecl forces the extension to be lower case even though it is given the actual extension. Removing the lowercasing allows more flexibility in the file naming. The problem only occurs when the libecl summary reader is used, the opm-common can already import these files. Fixes #10720. Fixes #10617.
|
This is probably the same issue that I ran into in #8385. |
magnesj
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…name and extension.
Importing files with different casing in base name and extension would fail when using libecl summary reader. E.g "norne_atw2013.SMSPEC" would fail since libecl forces the extension to be lower case even though it is given the actual extension.
Removing the lowercasing allows more flexibility in the file naming.
The problem only occurs when the libecl summary reader is used, the opm-common can already import these files.
Fixes #10720.
Fixes #10617.