Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10678 fault reactivation more materials #10721

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

kriben
Copy link
Collaborator

@kriben kriben commented Oct 16, 2023

Fixes #10678.

@kriben kriben force-pushed the 10678-fault-reactivation-more-materials branch from 843fa6d to e37333a Compare October 16, 2023 11:34
@kriben kriben force-pushed the 10678-fault-reactivation-more-materials branch from e37333a to 65abd13 Compare October 18, 2023 07:39
@kriben kriben requested a review from magnesj October 18, 2023 07:54
Copy link
Member

@magnesj magnesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to be considered.

@@ -126,7 +134,8 @@ std::pair<bool, std::string> RifFaultReactivationModelExporter::printParts(
const std::map<RimFaultReactivation::GridPart, std::string>& partNames,
const std::vector<std::pair<RimFaultReactivation::BorderSurface, std::string>>& borders,
const std::map<std::pair<RimFaultReactivation::GridPart, RimFaultReactivation::BorderSurface>, int>& faces,
const std::map<RimFaultReactivation::Boundary, std::string>& boundaries )
const std::map<RimFaultReactivation::Boundary, std::string>& boundaries,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving enum RimFaultReactivation to RigFaultReactivation

@kriben kriben merged commit ff22869 into dev Oct 18, 2023
17 checks passed
@kriben kriben deleted the 10678-fault-reactivation-more-materials branch October 18, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fault Reactivation: Add more materials
2 participants