Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of AICD valve definition from text file #10525

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Import of AICD valve definition from text file #10525

merged 3 commits into from
Sep 12, 2023

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Aug 21, 2023

Closes #10107

@magnesj magnesj force-pushed the 10107-import-aicd-templates branch from fa62ecb to 9b52025 Compare September 6, 2023 07:28
@magnesj magnesj marked this pull request as ready for review September 7, 2023 13:01
@magnesj magnesj requested a review from jonjenssen September 7, 2023 13:01
@magnesj magnesj force-pushed the 10107-import-aicd-templates branch from f80f899 to 91f116a Compare September 8, 2023 06:54
@magnesj magnesj force-pushed the 10107-import-aicd-templates branch from fb4e38f to 53da5d9 Compare September 8, 2023 08:04
@magnesj magnesj requested review from kriben and removed request for jonjenssen September 12, 2023 11:57
kriben
kriben requested changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@kriben kriben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readable code: some minor nitpicks as always.

ApplicationLibCode/Commands/CompletionCommands/RicImportValveTemplatesFeature.cpp Show resolved Hide resolved
ApplicationLibCode/FileInterface/RifEclipseInputFileTools.cpp Outdated Show resolved Hide resolved
ApplicationLibCode/ProjectDataModel/Completions/RimValveTemplate.cpp Outdated Show resolved Hide resolved
ApplicationLibCode/ProjectDataModel/RiaOpmParserTools.cpp Outdated Show resolved Hide resolved
@magnesj magnesj merged commit 13b4c19 into dev Sep 12, 2023
@magnesj magnesj deleted the 10107-import-aicd-templates branch September 12, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriben kriben kriben requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import of AICD valve definition from text file
2 participants
@magnesj @kriben