Fix of #281: Crash while importing - cvfPlane.cpp Aborted

OPM · Feb 24, 2015 · 27ce185 · 27ce185
1 parent 3b914c7
commit 27ce185
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/ApplicationCode/ModelVisualization/RivPipeGeometryGenerator.cpp b/ApplicationCode/ModelVisualization/RivPipeGeometryGenerator.cpp
@@ -336,7 +336,11 @@ cvf::ref<cvf::DrawableGeo> RivPipeGeometryGenerator::generateExtrudedCylinder(do
 
         cvf::Vec3d intersectionPlaneNormal = candidateDir + nextDir;
 
-        // if (intersectionPlaneNormal.lengthSquared() < 1e-10) intersectionPlaneNormal = nextDir; // candidateDir == -nextDir => 180 deg turn
+        if (intersectionPlaneNormal.lengthSquared() < 1e-10) // candidateDir == -nextDir => 180 deg turn
+        {
+            CVF_ASSERT(false); // This is never supposed to happen due to what's done in updateFilteredPipeCenterCoords(). So look there for the bug... 
+            intersectionPlaneNormal = nextDir; 
+        }
 
         computeExtrudedCoordsAndNormals(secondCoord, intersectionPlaneNormal, candidateDir, crossSectionNodeCount, &extrudedNodes, &crossSectionVertices, &cylinderSegmentNormals);
     }
@@ -521,11 +525,18 @@ void RivPipeGeometryGenerator::updateFilteredPipeCenterCoords()
         if (dotProduct > cosMinBendAngle)
         {
             bool success = false;
-            cvf::Vec3d pipeIntermediateDirection = (lastValidDirectionAB + directionBC.getNormalized()).getNormalized(&success);
-            if (!success)
+
+            cvf::Vec3d pipeIntermediateDirection = (lastValidDirectionAB + directionBC.getNormalized());
+            pipeIntermediateDirection.getNormalized(&success);
+
+            if (pipeIntermediateDirection.lengthSquared() < squareDistanceTolerance)
             {
                 pipeIntermediateDirection = lastValidDirectionAB.perpendicularVector();
             }
+            else
+            {
+                pipeIntermediateDirection.normalize();
+            }
 
             double bendRadius = m_bendScalingFactor * m_radius + 1.0e-30;
             cvf::Vec3d firstIntermediate = coordB - pipeIntermediateDirection * bendRadius;