Add new "grey" hero variant #3450
Open
+426
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/165/analysis-hero
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
admilne
reviewed
Dec 18, 2024
.../bitmaps_reference/ds-vr-test__components_hero_example-hero-analysis_0_document_1_tablet.png
Outdated
Show resolved
Hide resolved
.../bitmaps_reference/ds-vr-test__components_hero_example-hero-analysis_0_document_2_mobile.png
Outdated
Show resolved
Hide resolved
rmccar
requested changes
Dec 19, 2024
admilne
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Worth checking the margin below the topic. It looks like the gap is smaller in the design
There was a problem hiding this comment.
I think we may have a slight issue with the description list. One of the requirements is:
description list component added horizontally and it can include text or hyperlinks - https://jira.ons.gov.uk/browse/ONSDESYS-189
I don't think we can currently have links in here.
admilne
approved these changes
Dec 20, 2024
|
Now this is called the "grey" variant the title and description should be updated |
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 6, 2025
rmccar
reviewed
Jan 10, 2025
|
The Breadcrumbs component was adding undefined to its classes when no class was provided in the example. So, I added default('') to it in the code. |
rmccar
reviewed
Jan 13, 2025
|
Would you be able to rewrite the description, it doesn't really describe the change |
Co-authored-by: rmccar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-165....
Created new Hero variant as per the Figma.It has a grey background with logo on the right.
This new variant will also have Breadcrumbs, title, sub-header and horizontal description list(link to the PR)
Prototype link
Due to the changes in the HTML structure, I adjusted the styling by removing the margin applied to the text element when followed by a button. Instead, I added a margin to the top of the button to ensure consistent spacing.
How to review this PR
Check that new src/components/hero/example-hero-grey.njk in Hero component matches the figma design
Checklist
This needs to be completed by the person raising the PR.