Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add types to files #923

Merged
merged 15 commits into from
Aug 3, 2021
Merged

refactor: add types to files #923

merged 15 commits into from
Aug 3, 2021

Conversation

SkyeYoung
Copy link
Member

@SkyeYoung SkyeYoung commented Jul 26, 2021 •
edited
Loading

  1. Add missing eslint rules
  2. Add types of files under Link folder and optimize functions
  3. Add types of doc.js & relative files
  4. Add types of NavAndDrawer
  5. Add types of Search
  6. Add types of remaining files in the components folder
  7. Add type of pages

SkyeYoung added 2 commits July 25, 2021 23:11
@SkyeYoung
chore(.eslintrc.js): add missing rules
9f4c83f
@SkyeYoung
refactor(Link): add types, optimize functions
c990c6f 
But there is still a `<div> cannot appear as a descendant of <p>` problem that need to
be fixed in ToolCard.tsx
@SkyeYoung
Copy link
Member Author

这次慢慢来（

@SkyeYoung SkyeYoung force-pushed the support-ts-refactor branch from 78810d8 to 1068f5b Compare July 27, 2021 11:12
@SkyeYoung
Copy link
Member Author

快来 Review 掉一点啊，已经攒了四天的量啦。🙈

@SkyeYoung
Copy link
Member Author

预览地址：https://support-ts.surge.sh/

@SkyeYoung SkyeYoung requested a review from Enter-tainer July 29, 2021 12:27
@SkyeYoung
Copy link
Member Author

尝试修复了 #928，目前渲染正常了，但是本身的问题并没有解决。

@SkyeYoung SkyeYoung mentioned this pull request Jul 31, 2021
Open
@SkyeYoung SkyeYoung marked this pull request as ready for review July 31, 2021 09:52
Enter-tainer
Enter-tainer approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@Enter-tainer Enter-tainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reactive hast 这部分需要 @diauweb 看一下

@Enter-tainer
Copy link
Member

Enter-tainer commented Aug 2, 2021 •
edited
Loading

https://support-ts.surge.sh/tags
https://support-ts.surge.sh/test/changelog

changelog 和 tags 页面有 “编辑此页” 的图标，而按理说这两个页面是不应该有的。

不过看起来好像现在 ng 上面也有这个问题，可能是什么时候不小心给改错了，可以修一下

image

@SkyeYoung
Copy link
Member Author

@Enter-tainer 这个是因为默认 noEdit 是 false

@SkyeYoung
Copy link
Member Author

@Enter-tainer 要不要把 StyledLayout 里面的 noEdit 默认改为 true 呢

@Enter-tainer
Copy link
Member

处理一下 conflict 吧，处理掉就可以合了

@SkyeYoung
Copy link
Member Author

@Enter-tainer 冲突已处理。

@Enter-tainer Enter-tainer merged commit 6ed2195 into OI-wiki:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enter-tainer Enter-tainer Enter-tainer approved these changes

@diauweb diauweb diauweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkyeYoung @Enter-tainer @diauweb