Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce english locale when writing unique fraction cells #368

Merged
merged 5 commits into from
Sep 28, 2023
+9 −6
Merged

Enforce english locale when writing unique fraction cells #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d25769f
fixes #333
Apr 8, 2022
936a2c1
docs: fixes overlapped header
watilde May 13, 2022
0628914
Merge pull request #335 from watilde/fixes-margin-top
May 13, 2022
f26a94f
Update documentation to align wording with application
MaximMoinat Aug 8, 2022
5a05dc8
enforce english locale when writing unique fraction
thoniTUB Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/RabbitInAHat.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ <h2>Selecting Desired CDM Version</h2>
</div>
<div id="loading-in-a-custom-cdm" class="section level2">
<h2>Loading in a Custom CDM</h2>
<p>There are times when users might need to load in a customized version of the CDM, for instance if they are sandboxing new features. To load in a custom CDM schema, first you must create a CSV file that uses the same format as <a href="https://github.com/OHDSI/WhiteRabbit/blob/master/rabbitinahat/src/main/resources/org/ohdsi/rabbitInAHat/dataModel/CDMV5.csv">the existing CDMv5 schema file</a>.</p>
<p>There are times when users might need to load in a customized version of the CDM, for instance if they are sandboxing new features. To load in a custom CDM schema, first you must create a CSV file that uses the same format as <a href="https://github.com/OHDSI/WhiteRabbit/blob/master/rabbitinahat/src/main/resources/org/ohdsi/rabbitInAHat/dataModel">given for the CDM versions</a>.</p>
<p>Once you have created the CSV file, load it into RiaH as shown below:</p>
<div class="figure">
<img src="http://i.imgur.com/Tn9NKL3.gif" alt="" />
Expand Down
2 changes: 1 addition & 1 deletion docs/RabbitInAHat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ However, `person.associated_provider_id` exists only in CDMv4 (it was renamed to

## Loading in a Custom CDM
There are times when users might need to load in a customized version of the CDM, for instance if they are sandboxing new features.
To load in a custom CDM schema, first you must create a CSV file that uses the same format as [the existing CDMv5 schema file](https://github.com/OHDSI/WhiteRabbit/blob/master/rabbitinahat/src/main/resources/org/ohdsi/rabbitInAHat/dataModel/CDMV5.csv).
To load in a custom CDM schema, first you must create a CSV file that uses the same format as [given for the CDM versions](https://github.com/OHDSI/WhiteRabbit/blob/master/rabbitinahat/src/main/resources/org/ohdsi/rabbitInAHat/dataModel).

Once you have created the CSV file, load it into RiaH as shown below:

Expand Down
6 changes: 3 additions & 3 deletions docs/WhiteRabbit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ pagetitle: "White Rabbit"

## Scope and purpose
WhiteRabbit is a software tool to help prepare for ETLs (Extraction, Transformation, Loading) of longitudinal health care databases into the [Observational Medical Outcomes Partnership (OMOP) Common Data Model (CDM)](https://github.com/OHDSI/CommonDataModel).
The source data can be in delimited text files, SAS files, or in a database (MySQL, SQL Server, Oracle, PostgreSQL, Microsoft Access, Amazon RedShift, PDW, Teradata, Google BigQuery, Azure SQL Database).
The source data can be in delimited text files, SAS files, or in a database (MySQL, SQL Server, Oracle, PostgreSQL, Microsoft Access, Amazon RedShift, PDW, Teradata, Google BigQuery, Azure).
Note that for support of the OHDSI analytical tooling, the OMOP CDM will need to be in one of a limited set of database platforms (SQL Server, Oracle, PostgreSQL, Amazon RedShift, Google BigQuery, Impala).

WhiteRabbit’s main function is to perform a scan of the source data, providing detailed information on the tables, fields, and values that appear in a field.
Expand Down Expand Up @@ -67,7 +67,7 @@ Use the “Pick Folder” button to navigate in your local environment where you

Here you can specify the location of the source data.
The following source types are supported:
delimited text files, SAS files, MySQL, SQL Server, Oracle, PostgreSQL, Microsoft Access, Amazon RedShift, PDW, Teradata, Google BigQuery, Azure SQL Database.
delimited text files, SAS files, MySQL, SQL Server, Oracle, PostgreSQL, Microsoft Access, Amazon RedShift, PDW, Teradata, Google BigQuery, Azure.
Below are connection instructions for each data type of data source.
Once you have entered the necessary information, the “Test connection” button can ensure a connection can be made.

Expand Down Expand Up @@ -137,7 +137,7 @@ Authentication via service account credentials:
* _**Password:**_ OAuth private key path (full path to the private key JSON file)
* _**Database name:**_ data set name within ProjectID named in Server location field

#### Azure SQL Database
#### Azure

* _**Server location:**_ server address string including database name (e.g. `<project>.database.windows.net:1433;database=<database_name>`)
* _**User name:**_ name of the user used to log into the server
Expand Down
3 changes: 3 additions & 0 deletions docs/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
body {
margin-top: 60px;
}
.rmdimportant {
padding: 1em 1em 1em 4em;
margin-bottom: 10px;
Expand Down
2 changes: 1 addition & 1 deletion whiterabbit/src/main/java/org/ohdsi/whiteRabbit/scan/SourceDataScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ private void createFieldOverviewSheet() {
fieldInfo.nProcessed,
fieldInfo.getFractionEmpty(),
fieldInfo.hasValuesTrimmed() ? String.format("<= %d", uniqueCount) : uniqueCount,
fieldInfo.hasValuesTrimmed() ? String.format("<= %.3f", fractionUnique) : fractionUnique
fieldInfo.hasValuesTrimmed() ? String.format(Locale.ENGLISH, "<= %.3f", fractionUnique) : fractionUnique
));
if (calculateNumericStats) {
values.addAll(Arrays.asList(
Expand Down