Fix generation status query errors when source is deleted. #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added migration to alter views to not return any generations for sources that do not exist. Fixes #2360.
anthonysena
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added migration to alter views to not return any generations for sources that do not exist.
Fixes #2360.
There is a problem of consistency in the codebase about when entity graphs are used when the
@transactionalannotation is used, and the use of views to track generation info (ie: the source may be deleted but we can't set a foreign key to a spring batch job table based on astring_valuecolumn. We should have maintained our entity-specific generation status table instead of trying to generically use the job_execution table to store this. We will revisit this decision in WebAPI 3.0.