Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto select option when adding an "Auto concept ID column" #143

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Auto select option when adding an "Auto concept ID column" #143

merged 2 commits into from
Aug 15, 2022

Conversation

MaximMoinat
Copy link
Collaborator

Fixes #142

@MaximMoinat MaximMoinat changed the base branch from develop to master December 20, 2021 20:34
@MaximMoinat MaximMoinat changed the base branch from master to develop December 20, 2021 20:34
@MaximMoinat MaximMoinat linked an issue Dec 20, 2021 that may be closed by this pull request
Auto select auto map option if column is provided #142
Open
blootsvoets
blootsvoets approved these changes Dec 21, 2021
View reviewed changes
Copy link
Collaborator

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/org/ohdsi/usagi/ui/ImportDialog.java Outdated
@@ -232,6 +232,11 @@ private Component createColumnMappingPanel() {
autoConceptIdColumn = new JComboBox<>(comboBoxOptions);
autoConceptIdColumn.setToolTipText("The column containing a (semicolon-delimited) list of concept IDs to which the search will be restricted");
columnMappingPanel.add(autoConceptIdColumn, cBox);
autoConceptIdColumn.addActionListener(e -> {
if (!autoConceptIdColumn.getSelectedItem().toString().equals("")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually .isEmpty() is used for this check.

@MaximMoinat MaximMoinat merged commit 3db3fe8 into develop Aug 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-142 branch August 15, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blootsvoets blootsvoets blootsvoets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto select auto map option if column is provided
2 participants
@MaximMoinat @blootsvoets