-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for bringing DEV into PROD #6388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are for March 2024 - remove "empty.css" from webassets - remove lazy loading from carousel as now there are few items and is the largest section impacting the "Largest Contentful Paint", so we want the browser to prioritize loading the images - removed signup + verify popups from page template as they have been moved to a separate page - use <link rel="preconnect" to trigger DNS request for google fonts - refactored google recaptcha js to load only in pages where it is needed (large asset) - remove individual css file generation for: banner-styles, search-styles, onboarding-styles, onboarding-verify-styles, onboarding-survey-styles, - onboarding-styles included in onboarding-bulk-anon or onboarding-bulk-user (2 new css files)
…are for March 2024 - add rcssmin to requirements
…are for March 2024 - add rcssmin to requirements
HDX-9916 fix showcase action buttons
…-reenter-email HDX-9453 add tests for changing email during onboarding
…ng-live-dataset-filestores-resources HDX-8971 disable setting a filestore resources only dataset to live
…imize HDX-9070 - Discovery - Google Search Console - Core Web Vitals - Prep…
…are for March 2024 - optimize js bundles that are coming from vendor & base - move bundles in hdx_theme with similar naming - avoid using ckan vendor as no bundling possible - move jquery extra to bundle
…are for March 2024 - test reverting to lazy load for imgs
…imize HDX-9070 - Discovery - Google Search Console - Core Web Vitals - Prep…
…are for March 2024 - fix vendor loads + fontawesome
…are for March 2024 - load fontawesome from CDN instead of CKAN
PR: HDX-9927 add CSRF tokens
…imize Fix/hdx 9070 google search optimize
…ame-validation-logic HDX-9935 improve live feedback validation for username
…i-tutorial-url HDX-9944 update url of PowerBI tutorial
HDX-9906 update HDX logo
This fixed pagination when filtering by 2 orgs or by 2 tags
…blem PR HDX-9945 Fix for pagination when multi-valued filter is used
# Conflicts: # ckanext-hdx_theme/ckanext/hdx_theme/version.py
HDX-9955 fix js errors
…are for March 2024 - fix fontawesome for pages that don't inherit page.html
…imize HDX-9070 - Discovery - Google Search Console - Core Web Vitals - Prep…
- remove all old hdx_show_more references in templates
- fix add select2 in page-light bundle as responsive pages were missing the lib - fix i18n loaded after notify js for the custom org page - hdx_show_more bundle refactor
- fix loading search scripts instead of styles in search light template
- fix - no need for select2 css to be added again manually from templates, as it is part of the page styles bundle
- refactor show more bundle to be included in base page scripts
…imize Fix/hdx 9070 google search optimize
Also removing the PY3 suffix
- because google-analytics adds functions to hdx-util-lib
- some light pages (new onboarding) use a newer select2 v4. Both old and new select2 should NOT be loaded at the same time on a page (causes problems) - on the FAQ page, the select2.css needs to be loaded before other css
PR HDX-9962Bugfix/webassets fixes
…ignals-signup-form HDX-9969 improve HDX Signals signup form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.