Merge pull request #6340 from OCHA-DAP/feature/HDX-9878-implement-lan…

…ding-pages-feedback

HDX-9839 PR implement feedback for Signal & HAPI landing pages

ckanext-hdx_theme/ckanext/hdx_theme/fanstatic/bem.blocks/hero.css

@@ -40,7 +40,7 @@
   line-height: 28px;
 }
 .bem-hero__image {
-  max-height: 50px;
+  max-height: 45px;
 }
 .bem-hero__sections {
   color: #000;

ckanext-hdx_theme/ckanext/hdx_theme/hdx-styles/src/common/less/bem.blocks/hero.less

@@ -43,7 +43,7 @@
   }
 
   &__image {
-    max-height: 50px;
+    max-height: 45px;
   }
 
   &__sections {

ckanext-hdx_theme/ckanext/hdx_theme/helpers/ui_constants/landing_pages/hapi.py

@@ -1,7 +1,6 @@
 CONSTANTS = {
     'HERO_SECTION_TITLE': '''The HDX Humanitarian API (HAPI) is a way to access standardised indicators from multiple sources to automate workflows and visualisations''',
     'HERO_SECTION_DESCRIPTION': '''HAPI is in beta phase, and we are seeking feedback. To share your thoughts or join our Slack channel, send an email to <a href="{0}" title="Contact us">[email protected]</a>.''',
-    'HERO_SECTION_LABEL': '''HDX HAPI Beta''',
 
     'DATA_COVERAGE_SECTION_TITLE': '''Data Coverage''',
     'DATA_COVERAGE_SECTION_DESCRIPTION': '''Our initial coverage aligns with the data included in the <a href="{0}" target="_blank" data-module="hdx_click_stopper" data-module-link_type="hapi data coverage description" title="HDX Data Grids">HDX Data Grids</a>, which places the most important crisis data into six categories and 20 sub-categories. Our beta version of HAPI covers 57 indicators across 22 countries with a <a href="{1}" target="_blank" title="Humanitarian Response Plan" data-module="hdx_click_stopper" data-module-link_type="hapi data coverage description">Humanitarian Response Plan</a>.''',

ckanext-hdx_theme/ckanext/hdx_theme/templates/landing_pages/hapi.html

@@ -9,12 +9,12 @@
 {% endblock %}
 
 {% block content %}
-  {{ h.snippet('bem.blocks/hero.html', title=CONST.HERO_SECTION_TITLE, text=CONST.HERO_SECTION_DESCRIPTION.format('mailto:[email protected]'), label=CONST.HERO_SECTION_LABEL, sections=sections, click_stopper_link_type='hapi jump nav', spacing_class="mb-5") }}
+  {{ h.snippet('bem.blocks/hero.html', title=CONST.HERO_SECTION_TITLE, text=CONST.HERO_SECTION_DESCRIPTION.format('mailto:[email protected]'), image='/images/landing_pages/logo_hdx_hapi.png', sections=sections, click_stopper_link_type='hapi jump nav', spacing_class="mb-3") }}
 
   <div class="container">
 
     <div class="row" id="data-coverage">
-      <div class="col-12 mx-auto my-5">
+      <div class="col-12 mx-auto my-3">
         <div class="text-center mb-4">
           {{ h.snippet('bem.blocks/heading.html', title=CONST.DATA_COVERAGE_SECTION_TITLE, heading_type=3, spacing_class="mb-1") }}
           {{ h.snippet('bem.blocks/paragraph.html', text=CONST.DATA_COVERAGE_SECTION_DESCRIPTION.format('https://data.humdata.org/dashboards/overview-of-data-grids', 'https://humanitarianaction.info/document/global-humanitarian-overview-2024/article/response-plans-overview-2024'), paragraph_classes=["paragraph__text_font-size-medium", "mt-4"]) }}
@@ -33,7 +33,7 @@
     </div>
 
     <div class="row" id="be-inspired">
-      <div class="col-12 mx-auto my-5">
+      <div class="col-12 mx-auto my-3">
         <div class="text-center">
           {{ h.snippet('bem.blocks/heading.html', title=CONST.BE_INSPIRED_SECTION_TITLE, heading_type=3, spacing_class="mb-1") }}
           {{ h.snippet('bem.blocks/paragraph.html', text=CONST.BE_INSPIRED_SECTION_DESCRIPTION, paragraph_classes=["paragraph__text_font-size-big"]) }}
@@ -56,14 +56,14 @@
     </div>
 
     <div class="row" id="faq">
-      <div class="col-12 mx-auto my-5">
+      <div class="col-12 mx-auto my-3">
         {{ h.snippet('bem.blocks/heading.html', title=CONST.FAQ_SECTION_TITLE, heading_type=3) }}
         {{ h.snippet('bem.blocks/faq.html', data=faq_data) }}
       </div>
     </div>
   </div>
 
-  <div class="py-5 background-color-snow">
+  <div class="py-5 background-color-snow mt-3">
     <div class="container">
       <div class="row">
         <div class="col-12 mx-auto">

ckanext-hdx_theme/ckanext/hdx_theme/templates/landing_pages/page.html

@@ -15,6 +15,3 @@
 {% block header_core %}
   {% snippet 'header-mobile.html', page_has_desktop_version=False, page_has_mobile_version=False %}
 {% endblock %}
-
-{% block footer %}
-{% endblock %}

ckanext-hdx_theme/ckanext/hdx_theme/templates/landing_pages/signals.html

@@ -9,12 +9,12 @@
 {% endblock %}
 
 {% block content %}
-  {{ h.snippet('bem.blocks/hero.html', title=CONST.HERO_SECTION_TITLE, text=CONST.HERO_SECTION_DESCRIPTION.format('mailto:[email protected]'), image='/images/landing_pages/logo_hdx_signals.png', sections=sections, click_stopper_link_type='signals jump nav', spacing_class="mb-5") }}
+  {{ h.snippet('bem.blocks/hero.html', title=CONST.HERO_SECTION_TITLE, text=CONST.HERO_SECTION_DESCRIPTION.format('mailto:[email protected]'), image='/images/landing_pages/logo_hdx_signals.png', sections=sections, click_stopper_link_type='signals jump nav', spacing_class="mb-3") }}
 
   <div class="container">
 
     <div class="row" id="signup">
-      <div class="col-12 mx-auto my-5">
+      <div class="col-12 mx-auto my-3">
         <div class="text-center mb-4">
           {{ h.snippet('bem.blocks/heading.html', title=CONST.SIGNUP_SECTION_TITLE, heading_type=3, spacing_class="mb-1") }}
           <div class="row">
@@ -349,7 +349,7 @@
     </div>
 
     <div class="row" id="data-coverage">
-      <div class="col-12 mx-auto my-5">
+      <div class="col-12 mx-auto my-3">
         <div class="text-center mb-4">
           {{ h.snippet('bem.blocks/heading.html', title=CONST.DATA_COVERAGE_SECTION_TITLE, heading_type=3, spacing_class="mb-1") }}
           {{ h.snippet('bem.blocks/paragraph.html', text=CONST.DATA_COVERAGE_SECTION_DESCRIPTION, paragraph_classes=["paragraph__text_font-size-medium", "mt-4"]) }}
@@ -365,7 +365,7 @@
     </div>
 
     <div class="row" id="resources">
-      <div class="col-12 mx-auto my-5">
+      <div class="col-12 mx-auto my-3">
         <div class="text-center">
           {{ h.snippet('bem.blocks/heading.html', title=CONST.RESOURCES_SECTION_TITLE, heading_type=3, spacing_class="mb-1") }}
           {{ h.snippet('bem.blocks/paragraph.html', text=CONST.RESOURCES_SECTION_DESCRIPTION, paragraph_classes=["paragraph__text_font-size-big"]) }}
@@ -391,14 +391,14 @@
     </div>
 
     <div class="row" id="faq">
-      <div class="col-12 mx-auto my-5">
+      <div class="col-12 mx-auto my-3">
         {{ h.snippet('bem.blocks/heading.html', title=CONST.FAQ_SECTION_TITLE, heading_type=3) }}
         {{ h.snippet('bem.blocks/faq.html', data=faq_data) }}
       </div>
     </div>
   </div>
 
-  <div class="py-5 background-color-snow">
+  <div class="py-5 background-color-snow mt-3">
     <div class="container">
       <div class="row">
         <div class="col-12 mx-auto">

ckanext-hdx_theme/ckanext/hdx_theme/views/landing_pages.py

@@ -72,5 +72,5 @@ def signals():
     return render('landing_pages/signals.html', extra_vars=template_data)
 
 
-# hdx_landing_pages.add_url_rule(u'/hapi/', view_func=hapi, strict_slashes=False)
-# hdx_landing_pages.add_url_rule(u'/signals/', view_func=signals, strict_slashes=False)
+hdx_landing_pages.add_url_rule(u'/hapi/', view_func=hapi, strict_slashes=False)
+hdx_landing_pages.add_url_rule(u'/signals/', view_func=signals, strict_slashes=False)