Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_cookiebot: Migration to 16.0 #959

Closed

Conversation

NICO-SOLUTIONS
Copy link
Member

Standard migration

@NICO-SOLUTIONS
Copy link
Member Author

can anybody assist in understanding the failing tests?!

@pedrobaeza
Copy link
Member

Install and run pre-commit locally, that will reformat your code, or change this manually:

Selección_055

@NICO-SOLUTIONS
Copy link
Member Author

Many thanks pedro!
pre-commit was installed but i probably just forget something...
I dont know if the way of commiting that step is correct or rather meets the foreseen workflow.

How about the codecov tests? do i need to take these into account?

@NICO-SOLUTIONS
Copy link
Member Author

ok sorry for the noise guys.
just tried to get rid of the commits in between but i think i need some hint what i´ve done worng.

@pedrobaeza
Copy link
Member

@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 16.0-mig-website_cookiebot branch 2 times, most recently from c317bd8 to d4372fd Compare March 6, 2023 21:43
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Mar 6, 2023
13 tasks
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 16.0-mig-website_cookiebot branch 2 times, most recently from 41e194d to db565c3 Compare May 24, 2023 12:58
@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as draft June 28, 2023 11:53
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 16.0-mig-website_cookiebot branch 2 times, most recently from 5abf5da to 0b2bd3d Compare June 28, 2023 12:29
@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review June 28, 2023 12:47
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 16.0-mig-website_cookiebot branch 3 times, most recently from e515650 to 5646993 Compare July 2, 2023 08:06
Jairo Llopis and others added 6 commits July 26, 2023 11:56
- Reorganize templates.
- Make templates noupdate=0, because if user edits them, it will be in the COW'd, website-specific version, so no problem on that.
- Rename `cookiebot_id` to `cookiebot_dgid` to avoid confusion with X2many fields.
- Remove ICP support, as the DGID should be per website.
- Add ID placeholders to Cookie Declaration page editable sections.
- Ensure Google Analytic script is blocked before consenting statistics. FTR it wasn't actually being blocked.
- Improve instructions.
- Split README.
- Apply pre-commit.

@Tecnativa TT32828

[UPD] Update website_cookiebot.pot
[UPD] Update website_cookiebot.pot

[UPD] README.rst
Translated using Weblate (German)

Currently translated at 84.6% (11 of 13 strings)

Translation: website-15.0/website-15.0-website_cookiebot
Translate-URL: https://translation.odoo-community.org/projects/website-15-0/website-15-0-website_cookiebot/de/
@NICO-SOLUTIONS
Copy link
Member Author

closed due to merge in #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants