Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] website_ab_testing #817

Open
wants to merge 1 commit into
base: 13.0
Choose a base branch
from
Open

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Jan 28, 2021

(for now) Simple A/B testing functionality.

A/B testing a conversion rate optimization tool.
In A/B testing you show multiple (mostly two) variants of the same page and determine
by the rate of conversion which version / variant is best.

First you want to configure a target:

  1. Go to Website > A/B Testing > Targets;
  2. click Create;
  3. choose a name for your target e.g. 'More Sales' or 'More Members';
  4. configure the triggers (triggers generate conversions e.g. when a certain page is visited or when a visitor bought a product from the webshop);
  5. click Save.

Now we want to create different variants of our pages so we can potentially increase our conversion rate:

  • Go to the website editor;
  • go to your landing page;
  • on the top right click on A/B Testing and New Variant to create a different version of the page;
  • when you're done making variants make sure to enable A/B testing for the page by clicking the toggle in the A/B Testing menu

When your test has ran for some time we can find out which variant is best.
To find out which variant has lead to the most conversions, you can either
go to Website > A/B Testing > Conversions or click the Statistics button on the Target form.

@tarteo tarteo force-pushed the 13-ab-testing branch 3 times, most recently from c913c03 to 9379d83 Compare January 29, 2021 11:01
@tarteo
Copy link
Member Author

tarteo commented Jan 29, 2021

@OCA/website-maintainers It's impossible to comply with pre-commit flake8 and black:
https://github.com/OCA/website/pull/817/files#diff-607e05394c0dc3bcf4f71161020d011f8c070363191a5262f98770b318b793dfR8
flake8 wants a space between the comma and black don't.

@hbrunn
Copy link
Member

hbrunn commented Feb 1, 2021

@tarteo you can remove the comma altogether, this is a know bug in black

@tarteo tarteo force-pushed the 13-ab-testing branch 4 times, most recently from 7de2c3e to 543a8d0 Compare February 5, 2021 12:48
@bosd
Copy link

bosd commented Mar 6, 2021

LGTM!

Created some eye candy for this one.
icon
icon.pg

Alternative
icon2

Copy link
Contributor

@claudiagn claudiagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review ok! LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Apr 24, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-817-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 24, 2021
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-817-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[FIX] website_ab_testing: Prettier

[FIX] website_ab_testing: Prettier

[FIX] website_ab_testing: Prettier

[FIX] website_ab_testing: Prettier

[FIX] website_ab_testing: Prettier

[ADD] tests

[ADD] tests

[ADD] tests

Fixup

Fixup

Fixup
@dreispt
Copy link
Member

dreispt commented Nov 26, 2021

Tests are failing https://app.travis-ci.com/github/OCA/website/jobs/500908529#L1010

@Tardo
Copy link
Member

Tardo commented May 16, 2022

The problem is because the mock needs define the "website_id".

@gfcapalbo
Copy link

@tarteo You have a failing test : https://app.travis-ci.com/github/OCA/website/jobs/502825441#L1049
in

not_enabled = main.with_user(self.user_public).render()

your mock request has no website_id, it shoulkd be something similar to:
https://github.com/OCA/OCB/blob/13.0/addons/website_sale/tests/test_website_sale_pricelist.py#L197

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 12, 2023
@bosd
Copy link

bosd commented Feb 15, 2023

@tarteo What is the status of this one? Can this one be fixed?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 19, 2023
@tarteo
Copy link
Member Author

tarteo commented Feb 21, 2023

I'll look into it this week. The module works BTW it's just the tests failing.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 25, 2023
@bosd
Copy link

bosd commented Jun 25, 2023

Please add no stale, would love to have this feature added!!

@dreispt dreispt added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jun 29, 2023
@dreispt
Copy link
Member

dreispt commented Jun 29, 2023

Done.

@elvise
Copy link

elvise commented Aug 29, 2023

@tarteo great PR!

What is the status ?

@elvise
Copy link

elvise commented Sep 24, 2023

@tarteo just a gentle reminder 🙂

@tarteo
Copy link
Member Author

tarteo commented Oct 10, 2023

@tarteo just a gentle reminder 🙂

Don't think I'm gonna work on this anymore (only if my employer requires it). The module works, only a test is failing because the mock is not complete. Feel free to make a PR on https://github.com/tarteo/website/tree/13-ab-testing to fix it, I'll merge right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs fixing no stale Use this label to prevent the automated stale action from closing this PR/Issue. ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants