-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][ADD] website_ab_testing #817
base: 13.0
Are you sure you want to change the base?
Conversation
c913c03
to
9379d83
Compare
@OCA/website-maintainers It's impossible to comply with pre-commit flake8 and black: |
@tarteo you can remove the comma altogether, this is a know bug in black |
7de2c3e
to
543a8d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional review ok! LGTM 👍
This PR has the |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-817-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
[FIX] website_ab_testing: Prettier [FIX] website_ab_testing: Prettier [FIX] website_ab_testing: Prettier [FIX] website_ab_testing: Prettier [FIX] website_ab_testing: Prettier [ADD] tests [ADD] tests [ADD] tests Fixup Fixup Fixup
Tests are failing https://app.travis-ci.com/github/OCA/website/jobs/500908529#L1010 |
The problem is because the mock needs define the "website_id". |
@tarteo You have a failing test : https://app.travis-ci.com/github/OCA/website/jobs/502825441#L1049
your mock request has no website_id, it shoulkd be something similar to: |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@tarteo What is the status of this one? Can this one be fixed? |
I'll look into it this week. The module works BTW it's just the tests failing. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Please add no stale, would love to have this feature added!! |
Done. |
@tarteo great PR! What is the status ? |
@tarteo just a gentle reminder 🙂 |
Don't think I'm gonna work on this anymore (only if my employer requires it). The module works, only a test is failing because the mock is not complete. Feel free to make a PR on https://github.com/tarteo/website/tree/13-ab-testing to fix it, I'll merge right away. |
(for now) Simple A/B testing functionality.
A/B testing a conversion rate optimization tool.
In A/B testing you show multiple (mostly two) variants of the same page and determine
by the rate of conversion which version / variant is best.
First you want to configure a target:
Website
>A/B Testing
>Targets
;Create
;Save
.Now we want to create different variants of our pages so we can potentially increase our conversion rate:
A/B Testing
andNew Variant
to create a different version of the page;A/B Testing
menuWhen your test has ran for some time we can find out which variant is best.
To find out which variant has lead to the most conversions, you can either
go to
Website
>A/B Testing
>Conversions
or click theStatistics
button on the Target form.