Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] real_estate: Addon to manage real estate #17

Open
wants to merge 9 commits into
base: 16.0
Choose a base branch
from

Conversation

curonny
Copy link

@curonny curonny commented May 24, 2024

No description provided.

@rousseldenis
Copy link
Contributor

What I wanted on the first version is to inherit from all properties of res.partner(and even added ones). As an estate has all properties of addresses.

This approach has a drawback is the implementation it needs. But IMHO, the advantages have more pro than cons. I'm not too much in favor of these changes

@curonny
Copy link
Author

curonny commented May 27, 2024

What I wanted on the first version is to inherit from all properties of res.partner(and even added ones). As an estate has all properties of addresses.

This approach has a drawback is the implementation it needs. But IMHO, the advantages have more pro than cons. I'm not too much in favor of these changes

I understand your point, but one of the problems, which arose when trying to use the currently published version, is that the fields of res.partner many2one list the contacts and also the properties, which forces us to add unnecessary domains so as not to list the properties .
Actually, I think the ideal behavior should be to isolate it, and link it with a product or partner according to the need of each solution to be carried out on this basis.

@pedrobaeza
Copy link
Member

I agree it should be an isolated one with the needed m2o, or maybe fields sync.

@curonny
Copy link
Author

curonny commented Jun 14, 2024

@rousseldenis So, would it be possible to validate the PR, with the new approach?

Copy link
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all,
for a project I'm working on (16.0) I need the management of estate.
My needs are very basic at the moment so I could create my custom module, but if it possible to use an OCA one I am happier.
For what I can understand from the comments and the code, this version is "better" than the 13.0.
So if it is possible to update the commit to have a runboat to test I will do it.
Thanks

@curonny
Copy link
Author

curonny commented Sep 2, 2024

@jelenapoblet is this PR, the other PR it's closed

@jelenapoblet
Copy link

Got it @curonny , thank you! Is there anything else we can do to move this forward?

@curonny
Copy link
Author

curonny commented Sep 2, 2024

Got it @curonny , thank you! Is there anything else we can do to move this forward?

everything is done, waiting for approval

@rousseldenis
Copy link
Contributor

@curonny Could you provide migration scripts if needed ?

real_estate_latitude = fields.Float(digits=(10, 7))
real_estate_longitude = fields.Float(digits=(10, 7))
comment = fields.Html()
owner_ids = fields.Many2many(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be enhanced in order to support different kind of property (bare ownership, ....).

country_code = fields.Char(
related="country_id.code",
)
real_estate_latitude = fields.Float(digits=(10, 7))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are in the real estate model, so removing real_estateshould be great for both fields

@rousseldenis
Copy link
Contributor

@curonny Could you rebase ?

index=True,
)
active = fields.Boolean(default=True)
image = fields.Image(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use theimage.mixinpresent in v16 in order to manage all sizes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants