Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] shipment advice: Auto close incoming #132

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[14.0][IMP] shipment advice: Auto close incoming #132

merged 3 commits into from
Jul 12, 2024

Conversation

mt-software-de
Copy link
Contributor

This supersedes #128.

If a move is set to done or cancel incoming shipment advises will be also set to done
if all planned moves are done or cancelled.

cc
@jbaudoux
@rousseldenis
Could please close the other PR.

@OCA-git-bot
Copy link
Contributor

Hi @TDu, @jbaudoux,
some modules you are maintaining are being modified, check this out!

@mt-software-de
Copy link
Contributor Author

ping @henrybackman

@mt-software-de mt-software-de force-pushed the 14-shipment_advice-autovalidate branch 4 times, most recently from 2e02852 to cdfcf6d Compare July 9, 2024 16:19
vuwnevska
vuwnevska reviewed Jul 10, 2024
View reviewed changes
Copy link

@vuwnevska vuwnevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, minor comment

shipment_advice/models/shipment_advice.py Outdated Show resolved Hide resolved
jbaudoux
jbaudoux reviewed Jul 11, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not make unittest classmethod private
Can you put original author copyright where relevant (for the code coming from superseded PR)?

@jbaudoux
Copy link

jbaudoux commented Jul 11, 2024 •
edited
Loading

cc @TDu

@mt-software-de mt-software-de force-pushed the 14-shipment_advice-autovalidate branch from ea21f7f to bb30dab Compare July 11, 2024 10:23
@mt-software-de
Copy link
Contributor Author

I would not make unittest classmethod private Can you put original author copyright where relevant (for the code coming from superseded PR)?

I will rename the the methods and will remove the assert from all.
The states are already tested.

@mt-software-de
Copy link
Contributor Author

I would not make unittest classmethod private Can you put original author copyright where relevant (for the code coming from superseded PR)?

From the original PR is nothing left.

@mt-software-de mt-software-de force-pushed the 14-shipment_advice-autovalidate branch 2 times, most recently from 1e28a22 to 18ba93d Compare July 11, 2024 12:28
jbaudoux
jbaudoux approved these changes Jul 11, 2024
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it is easier to port commits across version if you don't touch generated files (README & index) in IMP and FIX PRs. Less risks to have conflicts
If using pre-commit, you can solve this with
export SKIP=oca-gen-addon-readme

@mt-software-de
Copy link
Contributor Author

FYI, it is easier to port commits across version if you don't touch generated files (README & index) in IMP and FIX PRs. Less risks to have conflicts
If using pre-commit, you can solve this with
export SKIP=oca-gen-addon-readme

Thx. That was a mistake i will remove it.

@mt-software-de
[IMP] shipment_advice: Auto close incoming advice
509b389 
If a move is processed the related incoming shipment advice
will be set to done if all planned moves are done or canceled
@mt-software-de mt-software-de force-pushed the 14-shipment_advice-autovalidate branch from 18ba93d to 2224ba2 Compare July 12, 2024 09:54
@mt-software-de
Copy link
Contributor Author

FYI, it is easier to port commits across version if you don't touch generated files (README & index) in IMP and FIX PRs. Less risks to have conflicts If using pre-commit, you can solve this with export SKIP=oca-gen-addon-readme

Done.

@jbaudoux
Copy link

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-132-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e7cfa7f into OCA:14.0 Jul 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 26c368b. Thanks a lot for contributing to OCA. ❤️

@sebalix sebalix mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuwnevska vuwnevska vuwnevska approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mt-software-de @OCA-git-bot @jbaudoux @vuwnevska