[ADD][REF] shipment_advice #126

vnikolayev1 · 2024-05-29T10:44:19Z

modified shipment_advice, so it has validate_when_fully_done method that sets shipment to done if its moves are in "done" state, updated tests.

[UPD] Update shipment_advice.pot

The name field was not filled with its default value '/' when the shipment was created from the calendar view. Ensure we get the default value '/' in name field through the action.

From the migration task, access to ir.actions.* needs sudo now... https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0#tasks-to-do-in-the-migration

When testing with `shopfloor_delivery_shipment` module, there was error in this module as below. That is because normal stock user is used in testing. So this commit is to add test with normal stock user to make sure UI works as expected. ``` odoo.exceptions.AccessError: You are not allowed to access 'Action Window' (ir.actions.act_window) records. This operation is allowed for the following groups: - Administration/Settings Contact your administrator to request access if necessary. ```

…eries to load

And filter available docks from a shipment to the current warehouse.

…er-tools

[UPD] Update stock_dock.pot

Signed-off-by sebalix

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-shipment_advice Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-shipment_advice/

Currently translated at 99.5% (225 of 226 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-shipment_advice Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-shipment_advice/it/

Currently translated at 100.0% (226 of 226 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-shipment_advice Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-shipment_advice/it/

vnikolayev1 · 2024-05-29T10:45:02Z

@mt-software-de

mt-software-de

Thanks for contributing.

shipment_advice/models/shipment_advice.py

shipment_advice/tests/test_shipment_advice.py

TDu · 2024-06-04T09:27:33Z

@vnikolayev1 Thanks for your contribution Could you check the pre-commit issue and the failing tests ?
Also you may already have seen it but there is this https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst document that give lots of tips and guidelines.
Could you read the part on commit message https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#git and update your commit message for this one.

mt-software-de · 2024-06-04T09:29:35Z

shipment_advice/tests/test_shipment_advice.py

Please do not change the existing tests, it is not needed.

Currently translated at 100.0% (226 of 226 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-shipment_advice Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-shipment_advice/it/

mt-software-de · 2024-06-19T07:17:56Z

shipment_advice/models/res_config_settings.py

+    shipment_advice_auto_validate = fields.Boolean(
+        string="Enable Shipment Advice Auto Validation",
+        config_parameter='shipment_advice.shipment_advice_auto_validate',
+    )


This should be a related field to the company.

Suggested change

shipment_advice_auto_validate = fields.Boolean(

string="Enable Shipment Advice Auto Validation",

config_parameter='shipment_advice.shipment_advice_auto_validate',

)

shipment_advice_auto_validate = fields.Boolean(

related="company_id.shipment_advice_auto_validate",

)

readonly=False

mt-software-de · 2024-06-19T07:21:42Z

shipment_advice/models/stock_move.py

+        res = super()._action_done(cancel_backorder=cancel_backorder)
+        for rec in self:
+            if rec.shipment_advice_id.shipment_type == "incoming":
+                auto_validate_enabled = self.env['ir.config_parameter'].sudo().get_param(
+                    'shipment_advice.shipment_advice_auto_validate', default=False)
+                if auto_validate_enabled:
+                    rec.shipment_advice_id._action_done()


You have to care about the result of the super call, this is returning the moves which are actually done.
As well the shipment advice should only be closed if every move is done. There call your new create method validate_when_fully_done

Suggested change

res = super()._action_done(cancel_backorder=cancel_backorder)

for rec in self:

if rec.shipment_advice_id.shipment_type == "incoming":

auto_validate_enabled = self.env['ir.config_parameter'].sudo().get_param(

'shipment_advice.shipment_advice_auto_validate', default=False)

if auto_validate_enabled:

rec.shipment_advice_id._action_done()

res = super()._action_done(cancel_backorder=cancel_backorder)

shipment_advices = res.shipment_advice_id

for shipment_advice in shipment_advices:

if shipment_advice.shipment_type != "incoming" or shipment_advice.company_id.shipment_advice_auto_validate:

continue

shipment_advice.validate_when_fully_done()

mt-software-de · 2024-06-19T07:23:22Z

shipment_advice/tests/test_shipment_advice.py

+    def test_validate_shipment_advice_when_fully_done(self):
+        picking = self._prepare_picking_with_two_packages()
+        line1, line2 = picking.move_line_ids
+        # Load first package in shipment advice 2
+        pl1 = line1.package_level_id
+        self._in_progress_shipment_advice(self.shipment_advice_out)
+        self.assertEqual(self.shipment_advice_out.state, "in_progress")
+        self._load_records_in_shipment(self.shipment_advice_out, pl1)
+        pl2 = line2.package_level_id
+        # Load second package into shipment advice
+        self._load_records_in_shipment(self.shipment_advice_out, pl2)
+        # Assign planned move_ids that are assigned to test function
+        self.shipment_advice_out.planned_move_ids = line2.move_id + line1.move_id
+        self.assertEqual(line1.move_id.state, "assigned")
+        self.assertEqual(line2.move_id.state, "assigned")
+        self.assertEqual(self.shipment_advice_out.state, "in_progress")
+        # Validating if moves in "incorrect" states do not trigger _action_done()
+        self.shipment_advice_out.validate_when_fully_done()
+        self.assertEqual(self.shipment_advice_out.state, "in_progress")
+        # Validating if moves in one "incorrect" state do not trigger _action_done()
+        line1.move_id.state = "done"
+        self.shipment_advice_out.validate_when_fully_done()
+        self.assertEqual(self.shipment_advice_out.state, "in_progress")
+        line2.move_id.state = "done"
+        self.shipment_advice_out.validate_when_fully_done()
+        self.assertEqual(self.shipment_advice_out.state, "done")
+        self.assertEqual(picking.state, "done")


In this test you should call the validate_when_full_done anymore.
I would be good to just validate the pickings. And afterwards check if the shipment advice is closed.

- modified shipment_advice, so whenever we set stock move to done, and if autovalidate shipment advice is enabled in company settings - we set shipment advice to done - updated tests, covered backorder.

vnikolayev1 · 2024-07-02T17:59:34Z

messed up with rebase, created new one #128

OCA-git-bot and others added 30 commits October 3, 2022 22:07

Initialize 16.0 branch

e6ca6fc

[IMP] update dotfiles [ci skip]

db530ab

[ADD] shipment_advice: manage (un)loading process

c52ca1d

[UPD] Update shipment_advice.pot

[UPD] README.rst

a847362

[ADD] icon.png

57ed6f1

shipment_advice 13.0.1.0.1

bfec3e3

[FIX] shipment_advice: fix creation from calendar

d0ddcbe

The name field was not filled with its default value '/' when the shipment was created from the calendar view. Ensure we get the default value '/' in name field through the action.

shipment_advice 13.0.1.1.0

0dc5b88

[FIX] shipment_advice: display mail thread widgets

0a6be87

shipment_advice 13.0.1.2.0

8ae81be

[IMP] shipment_advice: black, isort, prettier

244505e

[MIG] shipment_advice: Migration to 14.0

697c5f8

[IMP] shipment_advice: add hook to filter packages to list

012ce33

[UPD] Update shipment_advice.pot

e8c3c3d

[UPD] README.rst

10b688a

[14][FIX] shipment_advice read action error

151bcce

From the migration task, access to ir.actions.* needs sudo now... https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0#tasks-to-do-in-the-migration

shipment_advice 14.0.1.0.1

fa048fe

[FIX] shipment_advice: lock transfers during validation

92aeb55

[UPD] README.rst

41b98bb

shipment_advice 14.0.1.0.2

1032306

[FIX] shipment_advice: filter on current warehouse when listing deliv…

7c66a99

…eries to load

shipment_advice 14.0.1.0.3

4b67be4

[IMP] shipment: bind dock to a warehouse

d90de4d

And filter available docks from a shipment to the current warehouse.

[IMP] shipment_advice: add domain hook for deliveries to open

729263e

shipment_advice 14.0.1.1.0

88a54fd

shipment_advice: Fix widget to avoid deleting stock moves from advices

f1192eb

[IMP] shipment_advice: black, isort, prettier

d4b2497

Go through 'Migrate to version 15.0' and '... 14.0' from OCA/maintain…

a70cb51

…er-tools

[ADD] shipment_advice: manage (un)loading process

b7901ff

[UPD] Update stock_dock.pot

victorvermot and others added 8 commits April 3, 2024 12:59

[16.0][IMP] Add default value to run_in_queue_job field

6fbcd4e

Merge PR OCA#121 into 16.0

59734f4

Signed-off-by sebalix

[UPD] Update shipment_advice.pot

8d710e4

[BOT] post-merge updates

d5b8d7c

[IMP] update dotfiles

487d71c

vnikolayev1 force-pushed the 14.0-shipment_advice_done_ref branch from 476b56b to 4dc3221 Compare May 29, 2024 14:11

mt-software-de suggested changes May 29, 2024

View reviewed changes

shipment_advice/models/shipment_advice.py Outdated Show resolved Hide resolved

shipment_advice/tests/test_shipment_advice.py Show resolved Hide resolved

vnikolayev1 force-pushed the 14.0-shipment_advice_done_ref branch 2 times, most recently from cf9d5aa to 458fad1 Compare May 30, 2024 11:57

mt-software-de suggested changes Jun 4, 2024

View reviewed changes

shipment_advice/tests/test_shipment_advice.py

Copy link

Contributor

mt-software-de Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the existing tests, it is not needed.

vnikolayev1 force-pushed the 14.0-shipment_advice_done_ref branch 3 times, most recently from 5057166 to 315c0d6 Compare June 11, 2024 10:12

vnikolayev1 force-pushed the 14.0-shipment_advice_done_ref branch from 315c0d6 to 7bfce51 Compare June 19, 2024 06:06

mt-software-de suggested changes Jun 19, 2024

View reviewed changes

rafaelbn added this to the 14.0 milestone Jun 19, 2024

rafaelbn added the needs review label Jun 19, 2024

vnikolayev1 force-pushed the 14.0-shipment_advice_done_ref branch 2 times, most recently from 0a8d74a to 9d98dd3 Compare June 20, 2024 22:40

[ADD][IMP] shipment_advice

f0a4e11

- modified shipment_advice, so whenever we set stock move to done, and if autovalidate shipment advice is enabled in company settings - we set shipment advice to done - updated tests, covered backorder.

vnikolayev1 closed this Jun 20, 2024

vnikolayev1 force-pushed the 14.0-shipment_advice_done_ref branch from 9d98dd3 to f0a4e11 Compare June 20, 2024 22:54

vnikolayev1 mentioned this pull request Jun 21, 2024

[14.0][IMP] shipment_advice: Autovalidate #128

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][REF] shipment_advice #126

[ADD][REF] shipment_advice #126

vnikolayev1 commented May 29, 2024

vnikolayev1 commented May 29, 2024

mt-software-de left a comment

TDu commented Jun 4, 2024

mt-software-de Jun 4, 2024

mt-software-de Jun 19, 2024

vuwnevska Jun 19, 2024

mt-software-de Jun 19, 2024

mt-software-de Jun 19, 2024

vnikolayev1 commented Jul 2, 2024

[ADD][REF] shipment_advice #126

[ADD][REF] shipment_advice #126

Conversation

vnikolayev1 commented May 29, 2024

vnikolayev1 commented May 29, 2024

mt-software-de left a comment

Choose a reason for hiding this comment

TDu commented Jun 4, 2024

mt-software-de Jun 4, 2024

Choose a reason for hiding this comment

mt-software-de Jun 19, 2024

Choose a reason for hiding this comment

vuwnevska Jun 19, 2024

Choose a reason for hiding this comment

mt-software-de Jun 19, 2024

Choose a reason for hiding this comment

mt-software-de Jun 19, 2024

Choose a reason for hiding this comment

vnikolayev1 commented Jul 2, 2024