Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] stock_barcodes_picking_batch_revision: Migration to version 16.0 #632

Open
wants to merge 5 commits into
base: 16.0
Choose a base branch
from

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Jul 29, 2024

@sergio-teruel sergio-teruel marked this pull request as draft July 29, 2024 10:24
@sergio-teruel sergio-teruel force-pushed the 16.0-mig-stock_barcodes_picking_batch_revision branch from 053d687 to 7a64163 Compare July 31, 2024 10:18
@sergio-teruel sergio-teruel marked this pull request as ready for review August 1, 2024 08:22
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes to improve the readeability of the toggle (to a bigger extent, the former toggle styles had way better ux)

Peek 04-09-2024 14-52

Comment on lines 16 to 22
<field
name="barcodes_requested_review"
widget="boolean_toggle_big"
/>
<label for="barcodes_requested_review">
Review
</label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field
name="barcodes_requested_review"
widget="boolean_toggle_big"
/>
<label for="barcodes_requested_review">
Review
</label>
<label for="barcodes_requested_review" class="me-2">
Review
</label>
<field
name="barcodes_requested_review"
widget="boolean_toggle_big"
/>

.o_boolean_toggle_big input.form-check-input{
width: 4em;
height: 2em;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}
.text-white {
.o_boolean_toggle_big input.form-check-input {
border-color: white;
}
}

@sergio-teruel sergio-teruel force-pushed the 16.0-mig-stock_barcodes_picking_batch_revision branch from 7a64163 to 69c9052 Compare September 5, 2024 11:58
@sergio-teruel
Copy link
Contributor Author

Changes Done!

@pedrobaeza
Copy link
Member

/ocabot migration stock_barcodes_picking_batch_revision

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 5, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 5, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants