[16.0][ADD] product_packaging_multi_barcode_stock_menu: view packaging on barcode list

[santostelmo]

Show packaging field in product barcode tree view

[sebalix]

Cannot do that, product.barcode.packaging_id field is part of product_packaging_multi_barcode module, so this doesn't respect the inheritance.

[santostelmo]

product_packaging_multi_barcode

@sebalix Should I make product_multi_barcode_stock_menu dependent of product_packaging_multi_barcode ?

[sebalix]

@santostelmo no we cannot do that neither sadly. I think the way it has been designed, we have to create a product_packaging_multi_barcode_stock_menu module to handle this need.
I know its overkill but I do not see another solution.

In the long term, as both product and packaging are part of Odoo std (product module), I'm wondering why product_multi_barcode and product_packaging_multi_barcode couldn't be merge in one module (you install it and you get all your models coming from product extended with this multi barcodes feature), so we could have only one extra module that make the glue between product_multi_barcode with stock (without restricting this to a menu, so a better name would have been product_multi_barcode_stock for instance).
But I don't know these modules nor why it has been designed this way, so for now we have to stick with what we have.

cc @simahawk

[santostelmo]

@santostelmo no we cannot do that neither sadly. I think the way it has been designed, we have to create a product_packaging_multi_barcode_stock_menu module to handle this need. I know its overkill but I do not see another solution.

In the long term, as both product and packaging are part of Odoo std (product module), I'm wondering why product_multi_barcode and product_packaging_multi_barcode couldn't be merge in one module (you install it and you get all your models coming from product extended with this multi barcodes feature), so we could have only one extra module that make the glue between product_multi_barcode with stock (without restricting this to a menu, so a better name would have been product_multi_barcode_stock for instance). But I don't know these modules nor why it has been designed this way, so for now we have to stick with what we have.

cc @simahawk

@sebalix I have created the module product_packaging_multi_barcode_stock_menu

[sebalix]

Thank you, would like to hear another opinion about this though, as I do not know these modules a lot

[QuocDuong1306]

Ping @santostelmo , Could you help to fix this?

[santostelmo]

@QuocDuong1306 I fixed the points mentioned above. @sebalix could you please check your change requests ?

[sebalix]

LG, can you add (in a separate commit) a ROADMAP.rst entry in product_packaging_multi_barcode module to merge it in product_multi_barcode for the next migration, and same for product_packaging_multi_barcode_stock_menu + product_multi_barcode_stock_menu to merge them in a new module product_multi_barcode_stock.

At the end we'll get only two modules, one depending exclusively on product, the other one being a glue module extending the first by adding a dependency on stock.

[cyrilmanuel]

Not an expert but LGTM

[cyrilmanuel]

missing script on pre to change module name if its already installed

[simahawk]

@ilyasProgrammer ping

[simahawk]

we need a manual version change here as we'll have to merge the PR w/ nobump

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[simahawk]

@santostelmo this PR deserves a better description explaining the changes 😉

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.