-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] mail_environment_office365 #119
Conversation
See comment on #117 |
a603516
to
b3b5a76
Compare
b3b5a76
to
281dfa8
Compare
Why not adding this one also? mail_environment_office365/models/fetchmail_server.py from odoo import models
class FetchmailServer(models.Model):
_inherit = "fetchmail.server"
@property
def _server_env_fields(self):
base_fields = super()._server_env_fields
office365_fields = {
"use_microsoft_outlook_service": {},
}
office365_fields.update(base_fields)
return office365_fields |
microsoft_outlook_client_id = YOUR_OFFICE365_CLIENT_ID | ||
microsoft_outlook_client_secret = YOUR_OFFICE365_CLIENT_SECRET | ||
|
||
[outgoing_mail.office365_smtp_server] |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This PR has the |
I found a problem when using mail_environment in combination fetchmail_outlook, which is, as I understand, the ultimate goal of this module. The constraint https://github.com/odoo/odoo/blob/14.0/addons/fetchmail_outlook/models/fetchmail_server.py#L32 fails, because it is unable to detect the correct value of the environment variable fields from the environment. So, it may fail due to the server_type, or is_ssl, if those are defined in the server environment. It seems to me that at the time when the constraint is called the values have not been fetched from the environment variables. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
258766a
to
0fc77af
Compare
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 5201090. Thanks a lot for contributing to OCA. ❤️ |
Backport of #117