Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] mail_environment_office365 #119

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

ajaniszewska-dev
Copy link
Contributor

@ajaniszewska-dev ajaniszewska-dev commented Aug 16, 2022

Backport of #117

@simahawk
Copy link
Contributor

See comment on #117

@rven
Copy link

rven commented Sep 21, 2022

Why not adding this one also?

mail_environment_office365/models/fetchmail_server.py

from odoo import models


class FetchmailServer(models.Model):
    _inherit = "fetchmail.server"

    @property
    def _server_env_fields(self):
        base_fields = super()._server_env_fields
        office365_fields = {
            "use_microsoft_outlook_service": {},
        }
        office365_fields.update(base_fields)
        return office365_fields

@sebalix sebalix added this to the 14.0 milestone Oct 20, 2022
microsoft_outlook_client_id = YOUR_OFFICE365_CLIENT_ID
microsoft_outlook_client_secret = YOUR_OFFICE365_CLIENT_SECRET

[outgoing_mail.office365_smtp_server]

This comment was marked as outdated.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiBForgeFlow
Copy link
Member

I found a problem when using mail_environment in combination fetchmail_outlook, which is, as I understand, the ultimate goal of this module.

The constraint https://github.com/odoo/odoo/blob/14.0/addons/fetchmail_outlook/models/fetchmail_server.py#L32 fails, because it is unable to detect the correct value of the environment variable fields from the environment. So, it may fail due to the server_type, or is_ssl, if those are defined in the server environment. It seems to me that at the time when the constraint is called the values have not been fetched from the environment variables.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 28, 2023
@github-actions github-actions bot closed this Jul 2, 2023
@sebalix sebalix reopened this Sep 1, 2023
@sebalix
Copy link
Contributor

sebalix commented Sep 1, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-119-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a13a5e2 into OCA:14.0 Sep 1, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5201090. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants