[14.0] base_user_role: warning when adding admin to empty role #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaniszewska-dev
force-pushed
the
base_user_role_admin_fix
branch
4 times, most recently
from
d52fde8
to
2502d6c
Compare
ajaniszewska-dev
changed the title
When creating a new user role, it is possible to add a user to that role without having added any groups. If this is saved, all that user’s access rights will be wiped and he will not able to login anymore (Internal Server Error).
ajaniszewska-dev
force-pushed
the
base_user_role_admin_fix
branch
from
2502d6c
to
1921155
Compare
ivantodorovich
approved these changes
Sep 9, 2024
sebalix
reviewed
Sep 19, 2024
| @@ -19,6 +19,19 @@ class ResUsers(models.Model): | |||
| compute_sudo=True, | |||
| ) | |||
|
|
|||
| @api.onchange("role_line_ids") | |||
There was a problem hiding this comment.
I was thinking of a computed boolean field to display or not a <div class="alert alert-warning" role="alert"> in the forms, less intrusive than a popup. What do you think?
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-backend
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-backend (14.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new user role, it is possible to add a user to that role without having added any groups. If this is saved, all that user’s access rights will be wiped and he will not able to login anymore (Internal Server Error). It can cause problems when happens for admin user.