[15.0][FIX] change role_line_ids default value to override create

[PaoloYam]

Populating role_line_ids this way doesn't work in this case. The previous method indeed return the right value but at creation, role_line_ids is empty in vals resulting of a new user having no role attributed even though the default_user has one.

Feature already has test. Test added for coverage.

[OCA-git-bot]

Hi @novawish, @sebalix, @jcdrubay,
some modules you are maintaining are being modified, check this out!

[santostelmo]

Not sure this is the most correct way todo it. But it does the job

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[sebalix]

I am not sure to understand the change.
From a UX point of view, when I create a user (through the form view) I expect to see the role lines pre-populated thanks to the default attribute of the field, I can change them and then I expect these values to be stored as well when saving the form.

With the current changes we are losing this feature, roles will be populated when saving the form.

If your goal is to populate the roles when calling directly create, you can rework the code without losing the existing feature. Also, you should not force the default user roles if vals has them already set, only populate them if they were not set.

@api.model
def create(self, vals):
    if "role_line_ids" not in vals:
        # Populate roles from default user
    return super().create(vals)

Test cases:

• create({}) => no role defined, we populate roles from the default user
• create({'role_line_ids': False}) => we do not want to set any role on purpose, we do nothing
• create({'role_line_ids': [(6, 0, [IDs...]))} => roles have been defined with explicit values, same as previous example we do not add default user roles on top of that