Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [IMP] sale_mrp_bom: ensure bom_id can only be selected if right routing (manufacturing) is settle #3405

Draft
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Draft

[16.0] [IMP] sale_mrp_bom: ensure bom_id can only be selected if right routing (manufacturing) is settle #3405

wants to merge 2 commits into from
+91 −37

Conversation

rrebollo
Copy link

Fixes #3403.

@rrebollo rrebollo force-pushed the 16.0-imp-sale_mrp_bom-sale-order-line-bom-selection branch from fc733ba to b4015e9 Compare November 11, 2024 23:38
@rrebollo rrebollo force-pushed the 16.0-imp-sale_mrp_bom-sale-order-line-bom-selection branch from b4015e9 to 8f5f57a Compare November 11, 2024 23:52
@rrebollo
Copy link
Author

rrebollo commented Nov 12, 2024 •
edited
Loading

@arielbarreiros96 dear friend could you test this approach? I'm doing the bom_id field readonly if the routing is not properly settle.
I think right now I have covered the "Manufacture + MTO" case, "Manufacture + MTO + MTS" is not so clear to me. Could U show me some concrete example to reproduce?

@rrebollo
[IMP] sale_mrp_bom: disable edition for bom_id field in sale order li…
4f89b73 
…ne if product's manufacture routes aren't properly settle
@rrebollo rrebollo force-pushed the 16.0-imp-sale_mrp_bom-sale-order-line-bom-selection branch from 8f5f57a to 4f89b73 Compare November 12, 2024 00:11
@rrebollo
Copy link
Author

rrebollo commented Nov 13, 2024 •
edited
Loading

As a matter of fact, I believe this proposal aligns with the add-on's original intent, as stated in the usage section of the README: 'if the routing is manufacturing then...'

@rrebollo rrebollo changed the title [16.0] [IMP] sale_mrp_bom: disable edition for bom_id field in sale order line if product's manufacture routes aren't properly settle [16.0] [IMP] sale_mrp_bom: check for manufacturing routes Nov 13, 2024
@rrebollo rrebollo changed the title [16.0] [IMP] sale_mrp_bom: check for manufacturing routes [16.0] [IMP] sale_mrp_bom: add check for manufacturing routes Nov 13, 2024
arielbarreiros96
arielbarreiros96 reviewed Nov 18, 2024
View reviewed changes
Copy link

@arielbarreiros96 arielbarreiros96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a functional POV, for me, it seems quite better, now it doesn't allow you to select BoM on the sale.order.line unless the product has the manufacture and MTO routes. I can't recall a case in which I needed to set the BoM without using MTO.
I wasn't able to test the behavior when stock_mts_mto_rule is installed, which is slightly different from pure MTO

@rrebollo
Copy link
Author

thank U @arielbarreiros96 , do you mean this one?

@rrebollo rrebollo changed the title [16.0] [IMP] sale_mrp_bom: add check for manufacturing routes [16.0] [IMP] sale_mrp_bom: ensure bom_id can only be selected if right routing (manufacturing) is settle Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielbarreiros96 arielbarreiros96 arielbarreiros96 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rrebollo @arielbarreiros96