Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] sale_force_invoiced: update untaxed_amount_to_invoice #3101

Merged
merged 1 commit into from
May 18, 2024

Conversation

alessandro-fiorino
Copy link
Contributor

Recompute untaxed_amount_to_invoice on the sale order lines when force_invoiced is changed.
Issue #3093

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some remarks inline.
Otherwise, LGTM.

However, I don't use this module. I prefer original authors confirm this change is correct.

CC : @JordiBForgeFlow

sale_force_invoiced/models/sale_order.py Show resolved Hide resolved
sale_force_invoiced/models/sale_order.py Show resolved Hide resolved
Recompute untaxed_amount_to_invoice on the sale order lines when force_invoiced is changed.
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review
LGTM
thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented May 18, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3101-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit efed911 into OCA:16.0 May 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e950113. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants