Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_order_mass_action: Migration to 16.0 #2852

Open
wants to merge 16 commits into
base: 16.0
Choose a base branch
from

Conversation

jappi00
Copy link
Contributor

@jappi00 jappi00 commented Dec 14, 2023

No description provided.

@jappi00 jappi00 changed the title 16.0 mig sale order mass action [16.0][MIG] sale_order_mass_action: Migration to 16.0 Dec 14, 2023
@jappi00
Copy link
Contributor Author

jappi00 commented Dec 14, 2023

I hope I did everything right here, since it is my first migration. I have worked with this guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

I have no idea if here is anything right.

@jappi00 jappi00 force-pushed the 16.0-mig-sale_order_mass_action branch from 13a52df to 2bb82bf Compare December 14, 2023 12:42
@jappi00 jappi00 mentioned this pull request Dec 14, 2023
100 tasks
Copy link
Member

@victor-champonnois victor-champonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
Functional test : OK.
Regarding the code, I would just make a separate commit for the port to 15.0, in your case just having a commit changing the version number to 15.0, and another commit to 16.0.

Copy link

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_mass_action

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 6, 2024
@jappi00
Copy link
Contributor Author

jappi00 commented Dec 10, 2024

@rousseldenis i hope i did it right :D

@jappi00 jappi00 force-pushed the 16.0-mig-sale_order_mass_action branch from d5b1f3f to a817206 Compare December 10, 2024 13:33
@jappi00 jappi00 force-pushed the 16.0-mig-sale_order_mass_action branch from a817206 to 27de0e4 Compare December 10, 2024 13:35
@rousseldenis
Copy link
Contributor

@rousseldenis i hope i did it right :D

Nearly.

Could you amend your commit message like:

[IMP] sale_order_mass_action: Improve translation function call

@jappi00
Copy link
Contributor Author

jappi00 commented Dec 11, 2024

Will update it when iam later at home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants