Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch 18.0 [WAIT FOR MERGE] #36

Closed
wants to merge 2 commits into from
Closed

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Sep 13, 2024

Addresses v18 checklist OCA/maintainer-tools#628

How to obtain this result? Easy w/ OCA/repo-maintainer#20

oca-repo-add-branch --conf-dir ./conf/ --branch 18.0

That's it.

WAIT FOR MERGE TILL REST OF THE TOOLS ARE READY

@simahawk
Copy link
Contributor Author

I still have to address the use case to reuse answers from previous branch OCA/maintainer-tools#541

conf/repo/maintainer.yml Outdated Show resolved Hide resolved
@etobella
Copy link
Member

@simahawk @sbidoul Which answers do you want to reuse? Name description and so on are already on the configuration 🤔

@pedrobaeza
Copy link
Member

And this should wait until we update the configurations for this new branch.

@simahawk
Copy link
Contributor Author

@simahawk @sbidoul Which answers do you want to reuse? Name description and so on are already on the configuration 🤔

Agree, see OCA/maintainer-tools#541 (comment)

@sbidoul
Copy link
Member

sbidoul commented Sep 13, 2024

@simahawk can you explain how you this this PR in the PR description, as reference for the future?

@simahawk
Copy link
Contributor Author

@simahawk can you explain how you this this PR in the PR description, as reference for the future?

Sure, I'll also improve the README of the tool.

conf/repo/maintainer.yml Outdated Show resolved Hide resolved
conf/repo/ansible.yml Outdated Show resolved Hide resolved
conf/repo/connector.yml Outdated Show resolved Hide resolved
conf/repo/maintainer.yml Outdated Show resolved Hide resolved
conf/repo/mirrors.yml Outdated Show resolved Hide resolved
conf/repo/oca.yml Outdated Show resolved Hide resolved
conf/repo/oca.yml Outdated Show resolved Hide resolved
@simahawk simahawk removed the WIP label Sep 13, 2024
@simahawk simahawk changed the title Add branch 18.0 Add branch 18.0 [WAIT FOR MERGE TILL REST OF THE TOOLS ARE READY] Sep 13, 2024
conf/repo/oca.yml Outdated Show resolved Hide resolved
conf/repo/odoo-community.yml Outdated Show resolved Hide resolved
conf/repo/odoo-community.yml Outdated Show resolved Hide resolved
@simahawk simahawk force-pushed the add-v18 branch 2 times, most recently from 8f94733 to dee8ad7 Compare September 13, 2024 13:31
@simahawk simahawk changed the title Add branch 18.0 [WAIT FOR MERGE TILL REST OF THE TOOLS ARE READY] Add branch 18.0 [WAIT FOR MERGE] Sep 16, 2024
@pedrobaeza
Copy link
Member

@simahawk I have already switched default branch of OCB to 18.0 FYI in a direct commit for continuing with the rest of the needed changes for the foundation.

@sbidoul
Copy link
Member

sbidoul commented Sep 27, 2024

I suggest making a PR that creates the 18 branch on a couple of repos first, where someone is ready to do a PR to test the repo template.

@simahawk
Copy link
Contributor Author

simahawk commented Oct 4, 2024

Rebased

@simahawk
Copy link
Contributor Author

simahawk commented Oct 4, 2024

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to switch the default branch for all the repos to version 18?

@sbidoul
Copy link
Member

sbidoul commented Oct 6, 2024

Do we want to switch the default branch for all the repos to version 18?

I'm not sure. It would give the impression of empty repos everywhere in OCA.

@simahawk
Copy link
Contributor Author

simahawk commented Oct 6, 2024

Do we want to switch the default branch for all the repos to version 18?

It was in the checklist 😉

I'm not sure. It would give the impression of empty repos everywhere in OCA.

Yes, same feeling here. Yet, this is true even when you have 1 single module migrated :)

Personally I don't mind. I can roll back this change. What do you prefer?

We should probably improve the readme of the repos by including a message and a link to pull requests.
Something like "Migration in progress, bla bla bla. Please check $link".

@simahawk
Copy link
Contributor Author

simahawk commented Oct 7, 2024

@pedrobaeza @sbidoul there you go #41

@simahawk simahawk closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants