Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] product_configurator: Wizard reset #108

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

SirAionTech
Copy link
Contributor

Steps:

  1. Open a product in Configurator > Configurable templates
  2. Click Configure product
  3. Do a few steps
  4. Click Reset and confirm

Actual behavior:
The old configuration session is used in the popup: the values already selected are still selected.

Expected behavior:
The configuration session is deleted and a new configuration can be started from scratch

@OCA-git-bot
Copy link
Contributor

Hi @PCatinean,
some modules you are maintaining are being modified, check this out!

@SirAionTech SirAionTech marked this pull request as ready for review February 12, 2024 09:07
@dreispt
Copy link
Member

dreispt commented Feb 22, 2024

@Nikul-Chaudhary @Ammar-OSI can you please review?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 23, 2024
@SirAionTech SirAionTech force-pushed the 16.0-fix-product_configurator-wizard_reset branch from ae6b333 to 8ae8885 Compare June 25, 2024 08:41
@SirAionTech
Copy link
Contributor Author

Rebased on 16.0.

@Nikul-OSI
Copy link

Hello @SirAionTech @dreispt I tested in runbot and wizard reset from scratch. Here I shared video for reference.

Test: Fail

product_configurator.Wizard.reset.mp4

@SirAionTech
Copy link
Contributor Author

Hello @SirAionTech @dreispt I tested in runbot and wizard reset from scratch. Here I shared video for reference.

Test: Fail

product_configurator.Wizard.reset.mp4

Hi, thanks for the review!
The wizard should reset when you click on the RESET button, as specified in the 4th step of the PR description:

Click Reset and confirm

if you simply close the wizard, the behavior you are showing is the expected one.
Could you please try again and click the RESET button instead?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 30, 2024
@simahawk
Copy link
Contributor

@Nikul-OSI good for you?

@SirAionTech SirAionTech force-pushed the 16.0-fix-product_configurator-wizard_reset branch from 8ae8885 to 44659d5 Compare October 23, 2024 12:09
@SirAionTech
Copy link
Contributor Author

Rebased to resolve conflicts

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants