[FIX] pre-commit: update pylint odoo to enable valid-odoo-versions key for v18 #280
Conversation
sanderlienaerts
force-pushed
the
cf-pre-commit-update-pylint-odoo-to-enable-support-for-v18
branch
from
2d884e3
to
a32f783
Compare
| {%- set repo_rev.pyupgrade = "v2.38.2" %} | ||
| {%- set repo_rev.ruff = "v0.6.8" %} | ||
| {%- set repo_rev.setuptools_odoo = "3.1.8" %} | ||
| {%- endif %} | ||
|
|
||
| {%- if odoo_version > 16 %} | ||
| {%- set repo_rev.pylint_odoo = "v9.0.4" %} |
There was a problem hiding this comment.
By removing this v17 will have pylint_odoo = "v8.0.19" instead of "v9.0.4"
There was a problem hiding this comment.
{%- if odoo_version == 17 %}
{%- set repo_rev.pylint_odoo = "v9.0.4" %}
{%- endif %}
There was a problem hiding this comment.
Ah right, miss interpreted the conditions. So if v9.0.4 only applies to 17, we shouldn't remove the condition but instead modify to check for 17 only. In the previous state, the v9.1.2 for v17 and v18 were changed back to v9.0.4.
There was a problem hiding this comment.
Tihs is indeed easy to miss. I'd prefer adding a whole new section for v17, even if all the versions are identical to 16. So it is systematic, and easier to understand.
There was a problem hiding this comment.
A new section for v17 was added
sanderlienaerts
force-pushed
the
cf-pre-commit-update-pylint-odoo-to-enable-support-for-v18
branch
from
a32f783
to
7b08994
Compare
TIL. I'm adding a new checkbox in OCA/maintainer-tools#628, so we don't forget next time. |
sanderlienaerts
force-pushed
the
cf-pre-commit-update-pylint-odoo-to-enable-support-for-v18
branch
from
7b08994
to
c3fc659
Compare
|
Thanks! Can you use the same versions in the 16 and 17 sections (at first sight it looks like you cloned the 18 section for 17) ? |
I think it's correct what has been done here. Originally there is a part <16 and a part <18 (for v16 and v17). |
|
Ah, yes, it looks ok, now. Either I was review a previous version or I misread. Could you rebase to pickup the changes from #278? |
sanderlienaerts
force-pushed
the
cf-pre-commit-update-pylint-odoo-to-enable-support-for-v18
branch
from
c3fc659
to
19974a2
Compare
|
Changes are incorporated from |
sanderlienaerts
deleted the
cf-pre-commit-update-pylint-odoo-to-enable-support-for-v18
branch
Without updating the linter and using
valid-odoo-versions=18.0, pylint_odoo (mandatory check) passes green but without checking any rules.pylint-odoo unfortunately doesn't notify the user of 18.0 not being supported in v9.1.2. Support was added in v9.1.3 (OCA/pylint-odoo@v9.1.2...v9.1.3) in PR OCA/pylint-odoo#497
Example with
valid-odoo-versions=18.0andpylint-odoo==v1.9.2:Working example with
valid-odoo-versions=18.0andpylint-odoo==v1.9.3:Builds on: #272
pylint_odoo's version was also being overridden. This commit fixes that by adding a new v17 section.