Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] Mixed MR's #696

Closed
wants to merge 8 commits into from
Closed

[14.0] Mixed MR's #696

wants to merge 8 commits into from

Commits on Sep 17, 2024

  1. [IMP] purchase_sale_inter_company: make locking of target invoices op… 

    …tional.

In some cases people still want to modify the invoice.
    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f0ffddf View commit details
    Browse the repository at this point in the history

  2. [ADD] extra test cases for picking validation 

    - serial number product combined with regular product
- backorder created on serial number validation
    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e7fc4fb View commit details
    Browse the repository at this point in the history

  3. [IMP] purchase_sale_inter_company: support MRP "kit" products 

    Kit products (bom type = phantom) expand into several other products upon
picking creation. Before this commit, this caused the module to find
multiple destination moves per each move, since the matching was done
on sale order - purchases order link only. Here we add matching on product
also, which should fix this.
    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    82ac88d View commit details
    Browse the repository at this point in the history

  4. [UPD] set product_supplierinfo_inter_company and stock_intercompany t… 

    …o rebel module

For product_supplierinfo_inter_company, this introduces a hard requirement to configure
a pricelist on each supplier. This makes the tests of other modules fail because they do
not set these.

For stock_intercompany I don't know why it was set to rebel, it was done before
but not updated in the copier template, so just updating copier to reflect reality.
    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8dfc3b9 View commit details
    Browse the repository at this point in the history

  5. [ADD] purchase_sale_inter_company: Support returns 

    When a return is actioned on the SO side, also process the return on PO side.
    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    339e265 View commit details
    Browse the repository at this point in the history

  6. fixup! [ADD] purchase_sale_inter_company: Support returns

    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    51c5c4d View commit details
    Browse the repository at this point in the history

  7. [FIX] purchase_sale_inter_company: support discount 

    Currently when the sale order line has received a discount, and the SO is confirmed,
the undiscounted price is copied over to the PO, leading to a price discrepancy
between the SO and PO. With this commit, discount is respected.
    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a99ed68 View commit details
    Browse the repository at this point in the history

  8. [IMP] make picking state syncing configurable 

    By default picking state is forced to Done when SO picking is done, but if picking
sync fails, eg if there is a mismatch in SO and PO move lines, user can't correct
anything since the picking is already set to Done.

This may be acceptable in cases where 100% of the syncs go OK but we make the
setting configurable to support situations where manual corrections are needed.
    @thomaspaulb
    thomaspaulb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4f9dd6e View commit details
    Browse the repository at this point in the history