[15.0][IMP] Don't update session_info if display_switch_company_menu unset. #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amh-mw
commented
Aug 8, 2024
| if result.get("display_switch_company_menu"): | ||
| # Replace company name by company complete name in the session | ||
| # The values are used in the switch_company_menu widget (web module) | ||
| result["user_companies"]["current_company"] = user.company_id.id |
There was a problem hiding this comment.
This is the line that errors. Reproducible running stock odoo unit tests with --init mail,res_company_code. The user_companies value is not set for users without group base.group_user.
amh-mw
force-pushed
the
15.0-no_user_companies
branch
4 times, most recently
from
984441a
to
0d22571
Compare
This adds some defensive code to avoid an error updating session_info values that have not been populated.
amh-mw
force-pushed
the
15.0-no_user_companies
branch
from
0d22571
to
f171bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some defensive code to avoid an error updating session_info values that have not been populated.