This change is necessary to add quarterly period: Adding a quarter period type Improved fiscal period . Fixes #622 . #643

collokip169 · 2024-10-15T06:08:36Z

This pull request seeks to add quarterly period . Adding a quarter period type Improved fiscal period . Fixes #622 . #643

OCA-git-bot · 2024-10-15T06:08:40Z

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

collokip169 · 2024-10-15T06:10:55Z

Hi @sbidoul, some modules you are maintaining are being modified, check this out!

okay

collokip169 · 2024-10-15T06:11:12Z

okay

collokip169 · 2024-10-15T08:22:30Z

@thomaspaulb could you please review this when you have time?

thomaspaulb · 2024-10-15T09:00:13Z

This pull request implements the following features:

This needs to be in the description of the PR, you can edit it there and remove this

thomaspaulb · 2024-10-15T09:00:44Z

Please also fix pre-commit errors

…views

thomaspaulb · 2024-10-28T10:25:46Z

.pre-commit-config.yaml

Why are you adding an extra check?

thomaspaulb · 2024-10-28T10:25:59Z

git-diagnostics-2024-10-23-0823.zip

What is this ZIP file doing here

thomaspaulb · 2024-10-28T10:26:57Z

mis_builder_budget/models/mis_budget_abstract.py

You cant remove copyright headers

thomaspaulb · 2024-10-28T10:28:06Z

odoo-pre-commit-hooks

New submodule?

mis_builder_budget/views/mis_budget_by_account.xml

thomaspaulb · 2024-11-04T19:32:34Z

mis_builder/models/mis_report_instance.py

@@ -190,16 +203,18 @@ def _compute_dates(self):
            ("d", _("Day")),
            ("w", _("Week")),
            ("m", _("Month")),
+            ("q", _("quarterly")),


To be in line with the others, this needs to be capitalized and the "ly" removed

Capitalized

thomaspaulb · 2024-11-04T19:35:45Z

mis_builder/models/mis_report_instance.py

            ("y", _("Year")),
            ("date_range", _("Date Range")),
        ],
        string="Period type",
    )
-    is_ytd = fields.Boolean(
+    is_ytd = (


This change is a bit weird, normally it's not necessary to put brackets around a field definition

thomaspaulb · 2024-11-04T19:38:14Z

mis_builder/views/mis_report_instance.xml

-                            <field name="offset" />
-                            <field name="duration" />
+                            <field name="offset" string="Offset (Quarters)" attrs="{'invisible': [('type', '!=', 'q')]}"/>
+                            <field name="duration" string="Duration (Quarters)" attrs="{'invisible': [('type', '!=', 'q')]}"/>


This looks like a breaking change - why are people not allowed to see the offset and duration in other modes anymore? Eg for month offset and duration are also used, but now it would become invisible.

Not solved?

thomaspaulb · 2024-11-04T19:50:54Z

mis_builder/models/mis_report_instance.py

@@ -133,6 +133,19 @@ def _compute_dates(self):
                record.date_from = fields.Date.to_string(date_from)
                record.date_to = fields.Date.to_string(date_to)
                record.valid = True
+
+            elif record.mode == MODE_REL and record.type == "q":  # Quarterly period logic
+                date_from = d.replace(day=1)


This always takes the date_from as the start of the month, but in case of quarterly logic, it should be the start of the quarter that the d date falls in.

.pre-commit-config.yaml

thomaspaulb · 2024-11-06T13:43:03Z

mis_builder/models/mis_report_instance.py

@@ -133,6 +133,27 @@ def _compute_dates(self):
                record.date_from = fields.Date.to_string(date_from)
                record.date_to = fields.Date.to_string(date_to)
                record.valid = True
+
+            elif record.mode == MODE_REL and record.type == "Q":  # Quarterly period logic
+                date_from = d.month(month=1)


month is not a function it's an integer, so this gives an error

thomaspaulb · 2024-11-06T13:45:38Z

mis_builder/models/mis_report_instance.py

+                elif d.month in [7, 8, 9]:
+                    date_from = d.replace(month=7, day=1)  # Q3
+                else:
+                    date_from = d.replace(month=10, day=1)  # Q4


You could combine this to date_from = replace(month=(datetime(2024, 7, 7).month - 1) % 3 + 1)

thomaspaulb · 2024-11-06T13:46:02Z

mis_builder/views/mis_report_instance.xml

-                            <field name="offset" />
-                            <field name="duration" />
+                            <field name="offset" string="Offset (Quarters)" attrs="{'invisible': [('type', '!=', 'q')]}"/>
+                            <field name="duration" string="Duration (Quarters)" attrs="{'invisible': [('type', '!=', 'q')]}"/>


Not solved?

sbidoul · 2024-11-11T11:33:00Z

Hi, thanks a lot for contributing!

Could you please do a clean PR with only the changes to mis_builder, and nothing else: no changes to pre-commit config, no change to mis_builder_budget, ... I will then review.

pedrobaeza · 2024-11-11T11:38:33Z

And proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message and with green CI.

quarterly period

7494142

collokip169 marked this pull request as draft October 15, 2024 06:08

collokip169 marked this pull request as ready for review October 15, 2024 08:14

collokip169 marked this pull request as draft October 15, 2024 08:14

collokip169 marked this pull request as ready for review October 15, 2024 08:15

pre commit checks

304caf9

collokip169 changed the title ~~quarterly period~~ This pull request implements the following features: Adding a quarter period type Improved fiscal period . Fixes #622 . Oct 16, 2024

sbidoul and others added 5 commits October 16, 2024 18:26

[IMP] update dotfiles

be2d7e5

quartely period added to allow users search based on tree and serach …

f616a3e

…views

quarterly period with views

a903d92

quarterly period

0ed79a3

quartely period

870b71d

collokip169 marked this pull request as draft October 23, 2024 05:13

collokip169 changed the title ~~This pull request implements the following features: Adding a quarter period type Improved fiscal period . Fixes #622 .~~ This change is necessary to add quarterly period: Adding a quarter period type Improved fiscal period . Fixes #622 . Oct 23, 2024

pre-commit-hooks

033f6cd

thomaspaulb reviewed Oct 28, 2024

View reviewed changes

collinskipkorir added 2 commits November 4, 2024 15:53

quarterly period

a54c2df

quarterly period

806ac56

thomaspaulb suggested changes Nov 4, 2024

View reviewed changes

quarter period

0628040

collokip169 requested a review from thomaspaulb November 6, 2024 06:42

thomaspaulb suggested changes Nov 6, 2024

View reviewed changes

quarter period

e523cd6

collokip169 requested a review from thomaspaulb November 8, 2024 09:49

quarter period modified

54568d4

sbidoul mentioned this pull request Nov 11, 2024

Add files via upload #642

Closed

sbidoul added needs fixing and removed needs fixing labels Nov 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

This change is necessary to add quarterly period: Adding a quarter period type Improved fiscal period . Fixes #622 . #643

This change is necessary to add quarterly period: Adding a quarter period type Improved fiscal period . Fixes #622 . #643

collokip169 commented Oct 15, 2024 •

edited

Loading

OCA-git-bot commented Oct 15, 2024

collokip169 commented Oct 15, 2024

collokip169 commented Oct 15, 2024

collokip169 commented Oct 15, 2024

thomaspaulb commented Oct 15, 2024

thomaspaulb commented Oct 15, 2024

thomaspaulb Oct 28, 2024

thomaspaulb Oct 28, 2024

thomaspaulb Oct 28, 2024

thomaspaulb Oct 28, 2024

thomaspaulb Nov 4, 2024

thomaspaulb Nov 6, 2024

thomaspaulb Nov 4, 2024

thomaspaulb Nov 4, 2024

thomaspaulb Nov 6, 2024

thomaspaulb Nov 4, 2024

thomaspaulb Nov 6, 2024

thomaspaulb Nov 6, 2024

thomaspaulb Nov 6, 2024

sbidoul commented Nov 11, 2024

pedrobaeza commented Nov 11, 2024

This change is necessary to add quarterly period: Adding a quarter period type Improved fiscal period . Fixes #622 . #643

Are you sure you want to change the base?

This change is necessary to add quarterly period: Adding a quarter period type Improved fiscal period . Fixes #622 . #643

Conversation

collokip169 commented Oct 15, 2024 • edited Loading

OCA-git-bot commented Oct 15, 2024

collokip169 commented Oct 15, 2024

collokip169 commented Oct 15, 2024

collokip169 commented Oct 15, 2024

thomaspaulb commented Oct 15, 2024

thomaspaulb commented Oct 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbidoul commented Nov 11, 2024

pedrobaeza commented Nov 11, 2024

collokip169 commented Oct 15, 2024 •

edited

Loading