Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] mrp_production_date_planned_finished_calendar (fixes Mondays CI runs) #1398

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

LoisRForgeFlow
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow commented Nov 18, 2024

Fixes #1307. Continues discussion in #1388.

I will run CI everyday this week before merging to ensure that it is all good (not because of this module in particular but because of its interaction with mrp_multi_level in which tests do not have the dates frozen or hardcoded):

  • Monday
  • Tuesday
    (from here, manually running 15.0 pipelines)
  • Wednesday
  • Thursday
  • Friday
  • Saturday
  • Sunday

@OCA-git-bot
Copy link
Contributor

Hi @ivantodorovich,
some modules you are maintaining are being modified, check this out!

@LoisRForgeFlow LoisRForgeFlow force-pushed the 15.0-fix-mondays-ci branch 2 times, most recently from 62aa225 to 6a8d958 Compare November 18, 2024 14:42
@LoisRForgeFlow
Copy link
Contributor Author

@pedrobaeza This is the best way I found to fix the issue, what do you think?

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 18, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it seems enough for compatibilizing the modules.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1398-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5bb189f into OCA:15.0 Nov 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b423d5b. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-fix-mondays-ci branch November 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants